linux-kernel - Re: [PATCH v22 8/9] mm: memory_hotplug: disable memmap_on_memory when hugetlb_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 5 May 2021 16:06:36 -0700
From:   Mike Kravetz <mike.kravetz@...cle.com>
To:     Muchun Song <songmuchun@...edance.com>, corbet@....net,
        tglx@...utronix.de, mingo@...hat.com, bp@...en8.de, x86@...nel.org,
        hpa@...or.com, dave.hansen@...ux.intel.com, luto@...nel.org,
        peterz@...radead.org, viro@...iv.linux.org.uk,
        akpm@...ux-foundation.org, paulmck@...nel.org,
        pawan.kumar.gupta@...ux.intel.com, rdunlap@...radead.org,
        oneukum@...e.com, anshuman.khandual@....com, jroedel@...e.de,
        almasrymina@...gle.com, rientjes@...gle.com, willy@...radead.org,
        osalvador@...e.de, mhocko@...e.com, song.bao.hua@...ilicon.com,
        david@...hat.com, naoya.horiguchi@....com,
        joao.m.martins@...cle.com
Cc:     duanxiongchun@...edance.com, fam.zheng@...edance.com,
        zhengqi.arch@...edance.com, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH v22 8/9] mm: memory_hotplug: disable memmap_on_memory when
 hugetlb_free_vmemmap enabled

On 4/29/21 8:13 PM, Muchun Song wrote:
> The parameter of memory_hotplug.memmap_on_memory is not compatible with
> hugetlb_free_vmemmap. So disable it when hugetlb_free_vmemmap is
> enabled.
> 
> Signed-off-by: Muchun Song <songmuchun@...edance.com>
> ---
>  Documentation/admin-guide/kernel-parameters.txt | 8 ++++++++
>  drivers/acpi/acpi_memhotplug.c                  | 1 +
>  mm/memory_hotplug.c                             | 1 +
>  3 files changed, 10 insertions(+)

This seems to have taken all of Oscar's concerns and suggestions into
account.

Acked-by: Mike Kravetz <mike.kravetz@...cle.com>
-- 
Mike Kravetz