linux-kernel - Re: [PATCH 26/35] tty: make tty_operations::chars_in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 5 May 2021 12:43:50 +0200
From:   David Sterba <dsterba@...e.cz>
To:     Jiri Slaby <jslaby@...e.cz>
Cc:     gregkh@...uxfoundation.org, linux-serial@...r.kernel.org,
        linux-kernel@...r.kernel.org, Jeff Dike <jdike@...toit.com>,
        Richard Weinberger <richard@....at>,
        Anton Ivanov <anton.ivanov@...bridgegreys.com>,
        Arnd Bergmann <arnd@...db.de>,
        Samuel Iglesias Gonsalvez <siglesias@...lia.com>,
        Jens Taprogge <jens.taprogge@...rogge.org>,
        Karsten Keil <isdn@...ux-pingi.de>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Heiko Carstens <hca@...ux.ibm.com>,
        Vasily Gorbik <gor@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ibm.com>,
        David Lin <dtwlin@...il.com>, Johan Hovold <johan@...nel.org>,
        Alex Elder <elder@...nel.org>, Jiri Kosina <jikos@...nel.org>,
        David Sterba <dsterba@...e.com>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Oliver Neukum <oneukum@...e.com>,
        Felipe Balbi <balbi@...nel.org>,
        Mathias Nyman <mathias.nyman@...el.com>,
        Marcel Holtmann <marcel@...tmann.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        Luiz Augusto von Dentz <luiz.dentz@...il.com>
Subject: Re: [PATCH 26/35] tty: make tty_operations::chars_in_buffer return
 uint

On Wed, May 05, 2021 at 11:19:19AM +0200, Jiri Slaby wrote:
> tty_operations::chars_in_buffer is another hook which is expected to
> return values >= 0. So make it explicit by the return type too -- use
> unsigned int.
> 
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>
> Cc: Jeff Dike <jdike@...toit.com>
> Cc: Richard Weinberger <richard@....at>
> Cc: Anton Ivanov <anton.ivanov@...bridgegreys.com>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Samuel Iglesias Gonsalvez <siglesias@...lia.com>
> Cc: Jens Taprogge <jens.taprogge@...rogge.org>
> Cc: Karsten Keil <isdn@...ux-pingi.de>
> Cc: Ulf Hansson <ulf.hansson@...aro.org>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: Heiko Carstens <hca@...ux.ibm.com>
> Cc: Vasily Gorbik <gor@...ux.ibm.com>
> Cc: Christian Borntraeger <borntraeger@...ibm.com>
> Cc: David Lin <dtwlin@...il.com>
> Cc: Johan Hovold <johan@...nel.org>
> Cc: Alex Elder <elder@...nel.org>
> Cc: Jiri Kosina <jikos@...nel.org>
> Cc: David Sterba <dsterba@...e.com>
> Cc: Shawn Guo <shawnguo@...nel.org>
> Cc: Sascha Hauer <s.hauer@...gutronix.de>
> Cc: Oliver Neukum <oneukum@...e.com>
> Cc: Felipe Balbi <balbi@...nel.org>
> Cc: Mathias Nyman <mathias.nyman@...el.com>
> Cc: Marcel Holtmann <marcel@...tmann.org>
> Cc: Johan Hedberg <johan.hedberg@...il.com>
> Cc: Luiz Augusto von Dentz <luiz.dentz@...il.com>
> ---
>  drivers/tty/ipwireless/tty.c           |  2 +-

Acked-by: David Sterba <dsterba@...e.com>