[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 5 May 2021 13:17:27 +0200
From: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
To: Jonathan Cameron <Jonathan.Cameron@...wei.com>
Cc: <linuxarm@...wei.com>, <mauro.chehab@...wei.com>,
Fabio Estevam <festevam@...il.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
"Mauro Carvalho Chehab" <mchehab@...nel.org>,
NXP Linux Team <linux-imx@....com>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Philipp Zabel <p.zabel@...gutronix.de>,
Rui Miguel Silva <rmfrfs@...il.com>,
Sascha Hauer <s.hauer@...gutronix.de>,
Shawn Guo <shawnguo@...nel.org>,
Steve Longerbeam <slongerbeam@...il.com>,
<linux-arm-kernel@...ts.infradead.org>,
<linux-kernel@...r.kernel.org>, <linux-media@...r.kernel.org>,
<linux-staging@...ts.linux.dev>
Subject: Re: [PATCH 02/25] staging: media: imx7-mipi-csis: fix
pm_runtime_get_sync() usage count
Em Wed, 5 May 2021 12:06:52 +0100
Jonathan Cameron <Jonathan.Cameron@...wei.com> escreveu:
> On Wed, 5 May 2021 11:41:52 +0200
> Mauro Carvalho Chehab <mchehab+huawei@...nel.org> wrote:
>
> > The pm_runtime_get_sync() internally increments the
> > dev->power.usage_count without decrementing it, even on errors.
> > Replace it by the new pm_runtime_resume_and_get(), introduced by:
> > commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter")
> > in order to properly decrement the usage counter, avoiding
> > a potential PM usage counter leak.
> >
> > Acked-by: Rui Miguel Silva <rmfrfs@...il.com>
> > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
>
> Not a fix as far as I can see, just a cleanup - so perhaps not this set?
Yeah, will move it to the non-error patch pile and change the comments.
>
> Jonathan
>
>
> > ---
> > drivers/staging/media/imx/imx7-mipi-csis.c | 7 +++----
> > 1 file changed, 3 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c b/drivers/staging/media/imx/imx7-mipi-csis.c
> > index 025fdc488bd6..1dc680d94a46 100644
> > --- a/drivers/staging/media/imx/imx7-mipi-csis.c
> > +++ b/drivers/staging/media/imx/imx7-mipi-csis.c
> > @@ -695,11 +695,10 @@ static int mipi_csis_s_stream(struct v4l2_subdev *mipi_sd, int enable)
> >
> > mipi_csis_clear_counters(state);
> >
> > - ret = pm_runtime_get_sync(&state->pdev->dev);
> > - if (ret < 0) {
> > - pm_runtime_put_noidle(&state->pdev->dev);
> > + ret = pm_runtime_resume_and_get(&state->pdev->dev);
> > + if (ret < 0)
> > return ret;
> > - }
> > +
> > ret = v4l2_subdev_call(state->src_sd, core, s_power, 1);
> > if (ret < 0 && ret != -ENOIOCTLCMD)
> > goto done;
>
Thanks,
Mauro
Powered by blists - more mailing lists