linux-kernel - Re: [PATCH v1] spi: Don't have controller clean up spi device before driver unbind

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 5 May 2021 13:38:40 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Lukas Wunner <lukas@...ner.de>
Cc:     Saravana Kannan <saravanak@...gle.com>, kernel-team@...roid.com,
        linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] spi: Don't have controller clean up spi device before
 driver unbind

On Wed, May 05, 2021 at 07:48:38AM +0200, Lukas Wunner wrote:

> As I've written yesterday, calling spi_cleanup() in
> spi_unregister_device() should be fine if you move it to the end
> of the function, but before the final put_device().  For that,
> you need to open code the calls to device_del() and put_device()
> that happen in device_unregister() so far.

Indeed.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)