linux-kernel - Re: [PATCH v9 77/96] mm/filemap: Add filemap_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 6 May 2021 08:00:25 +0800
From:   kernel test robot <lkp@...el.com>
To:     "Matthew Wilcox (Oracle)" <willy@...radead.org>,
        linux-fsdevel@...r.kernel.org, linux-mm@...ck.org
Cc:     kbuild-all@...ts.01.org,
        "Matthew Wilcox (Oracle)" <willy@...radead.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v9 77/96] mm/filemap: Add filemap_alloc_folio

Hi "Matthew,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on next-20210505]
[cannot apply to hnaz-linux-mm/master xfs-linux/for-next tip/perf/core shaggy/jfs-next block/for-next linus/master asm-generic/master v5.12 v5.12-rc8 v5.12-rc7 v5.12]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Matthew-Wilcox-Oracle/Memory-folios/20210506-014108
base:    29955e0289b3255c5f609a7564a0f0bb4ae35c7a
config: x86_64-randconfig-s031-20210505 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-341-g8af24329-dirty
        # https://github.com/0day-ci/linux/commit/f694d0d59ba326a2db7840f6ff0a455620cdcaa1
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Matthew-Wilcox-Oracle/Memory-folios/20210506-014108
        git checkout f694d0d59ba326a2db7840f6ff0a455620cdcaa1
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>


sparse warnings: (new ones prefixed by >>)
>> mm/filemap.c:1000:52: sparse: sparse: incorrect type in argument 1 (different base types) @@     expected restricted gfp_t [usertype] gfp @@     got int [assigned] n @@
   mm/filemap.c:1000:52: sparse:     expected restricted gfp_t [usertype] gfp
   mm/filemap.c:1000:52: sparse:     got int [assigned] n
>> mm/filemap.c:1000:55: sparse: sparse: incorrect type in argument 2 (different base types) @@     expected unsigned int order @@     got restricted gfp_t [usertype] gfp @@
   mm/filemap.c:1000:55: sparse:     expected unsigned int order
   mm/filemap.c:1000:55: sparse:     got restricted gfp_t [usertype] gfp

vim +1000 mm/filemap.c

   988	
   989	#ifdef CONFIG_NUMA
   990	struct folio *filemap_alloc_folio(gfp_t gfp, unsigned int order)
   991	{
   992		int n;
   993		struct folio *folio;
   994	
   995		if (cpuset_do_page_mem_spread()) {
   996			unsigned int cpuset_mems_cookie;
   997			do {
   998				cpuset_mems_cookie = read_mems_allowed_begin();
   999				n = cpuset_mem_spread_node();
> 1000				folio = __alloc_folio_node(n, gfp, order);
  1001			} while (!folio && read_mems_allowed_retry(cpuset_mems_cookie));
  1002	
  1003			return folio;
  1004		}
  1005		return alloc_folio(gfp, order);
  1006	}
  1007	EXPORT_SYMBOL(filemap_alloc_folio);
  1008	#endif
  1009	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (34210 bytes)