linux-kernel - Re: [PATCH 25/35] tty: remove tty_operations::chars_in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YJOFAzDSMsVZbu3I@kroah.com>
Date:   Thu, 6 May 2021 07:56:19 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Jiri Slaby <jirislaby@...nel.org>
Cc:     linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
        Ivan Kokshaysky <ink@...assic.park.msu.ru>,
        Matt Turner <mattst88@...il.com>,
        "James E.J. Bottomley" <James.Bottomley@...senpartnership.com>,
        Helge Deller <deller@....de>, Chris Zankel <chris@...kel.net>,
        Max Filippov <jcmvbkbc@...il.com>,
        Heiko Carstens <hca@...ux.ibm.com>,
        Vasily Gorbik <gor@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ibm.com>,
        Richard Henderson <rth@...ddle.net>
Subject: Re: [PATCH 25/35] tty: remove tty_operations::chars_in_buffer for
 non-buffering

On Thu, May 06, 2021 at 07:47:04AM +0200, Jiri Slaby wrote:
> On 05. 05. 21, 11:19, Jiri Slaby wrote:
> > The only user of tty_ops::chars_in_buffer is tty_chars_in_buffer. And it
> > considers tty_ops::chars_in_buffer optional. In case it's NULL, zero is
> > returned. So remove all those chars_in_buffer from tty_ops which return
> > zero. (Zero means such driver doesn't buffer.)
> > 
> > Signed-off-by: Jiri Slaby <jslaby@...e.cz>
> 
> 
> > c: Richard Henderson <rth@...ddle.net>
> 
> Uh, "C" is a fugitive. Wanted dead or alive.
> 
> So should I send a v2 with:
> Cc: Richard Henderson <rth@...ddle.net>
> ?

Nah, it should be fine, I can fix it up.

thanks,

greg k-h