linux-kernel - Re: [PATCH v2] media: em28xx: Fix possible memory leak of em28xx struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cc3a655a-e29d-34f1-a1bb-faab01a1f756@xs4all.nl>
Date:   Thu, 6 May 2021 09:43:32 +0200
From:   Hans Verkuil <hverkuil-cisco@...all.nl>
To:     Shuah Khan <skhan@...uxfoundation.org>,
        Igor Matheus Andrade Torrente <igormtorrente@...il.com>,
        mchehab@...nel.org
Cc:     linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] media: em28xx: Fix possible memory leak of em28xx
 struct

On 05/05/2021 17:54, Shuah Khan wrote:
> On 5/4/21 2:32 PM, Igor Matheus Andrade Torrente wrote:
>> The em28xx struct kref isn't being decreased after an error in the
>> em28xx_ir_init, leading to a possible memory leak.
>>
>> A kref_put and em28xx_shutdown_buttons is added to the error handler code.
>>
>> Signed-off-by: Igor Matheus Andrade Torrente <igormtorrente@...il.com>
>> ---
> 
> Hi Igor,
> 
> Please look at Hans's response and comments to your v1 patch. v4l core
> addresses the lifetime issues now and this driver could be updated to
> use them instead if fixing the problems in this driver's resource
> lifetime mgmt code.

Actually, this patch is fine (I think, still need to review it). This is
related to the input part, not v4l2.

Regards,

	Hans

> 
> Please follow his review comments to address the issue based on his 
> suggestions.
> 
> thanks,
> -- Shuah
>