linux-kernel - 答复: [PATCH -next v4] bcache: Use DEFINE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 6 May 2021 08:32:43 +0000
From:   zhengyongjun <zhengyongjun3@...wei.com>
To:     Coly Li <colyli@...e.de>
CC:     pmail_hulkci <hulkci@...wei.com>,
        "kent.overstreet@...il.com" <kent.overstreet@...il.com>,
        "linux-bcache@...r.kernel.org" <linux-bcache@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: 答复: [PATCH -next v4] bcache: Use DEFINE_MUTEX() for mutex lock

I've been on a business trip some time ago and didn't do upstream work. Thanks for your patience:)

-----邮件原件-----
发件人: Coly Li [mailto:colyli@...e.de] 
发送时间: 2021年5月6日 11:27
收件人: zhengyongjun <zhengyongjun3@...wei.com>
抄送: pmail_hulkci <hulkci@...wei.com>; kent.overstreet@...il.com; linux-bcache@...r.kernel.org; linux-kernel@...r.kernel.org
主题: Re: [PATCH -next v4] bcache: Use DEFINE_MUTEX() for mutex lock

On 5/5/21 7:06 PM, Zheng Yongjun wrote:
> Mutex lock can be initialized automatically with DEFINE_MUTEX() rather 
> than explicitly calling mutex_init().
> 
> This patch will reduce the size of bcache.ko about 16 bytes, the 
> reason as follows:
> 
> Though this patch will increase the size of .data segment about 32 
> bytes, it will also reduce the size of .init.text and 
> .rodata.str1.1(at x86_64), .rodata_str1.8(at arm64) total about 48 
> bytes which reduce the size more than .data segment;
> 
> Here is the statistics:
> Sections: (arm64 platform)
> Idx name                size
> -.init.text             00000240
> +.init.text             00000228
> 
> -.rodata.str1.8	000012cd
> +.rodata.str1.8	000012b5
> 
> -.data                  00000c60
> +.data                  00000c80
> 
> Sections: (x86 platform)
> Idx name                size
> -.init.text             000001d9
> +.init.text             000001bf
> 
> -.rodata.str1.1	00000c80
> +.rodata.str1.1	00000c6d
> 
> -.data                  00000cc0
> +.data                  00000ce0
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@...wei.com>

Added in my for-test queue.

Thanks.

Coly Li

[snipped]