linux-kernel - Re: [PATCH] PCI: tegra: Fix host initialization during resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fecc2899-06ef-f91f-4a39-bb4ee664c800@nvidia.com>
Date:   Thu, 6 May 2021 09:49:15 +0100
From:   Jon Hunter <jonathanh@...dia.com>
To:     Vidya Sagar <vidyas@...dia.com>, <lorenzo.pieralisi@....com>,
        <robh@...nel.org>, <bhelgaas@...gle.com>,
        <thierry.reding@...il.com>, <jingoohan1@...il.com>,
        <gustavo.pimentel@...opsys.com>
CC:     <linux-pci@...r.kernel.org>, <linux-tegra@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <kthota@...dia.com>,
        <mmaddireddy@...dia.com>, <sagar.tv@...il.com>
Subject: Re: [PATCH] PCI: tegra: Fix host initialization during resume


On 04/05/2021 18:21, Vidya Sagar wrote:
> Commit 275e88b06a27 ("PCI: tegra: Fix host link initialization") broke
> host initialization during resume as it misses out calling the API
> dw_pcie_setup_rc() which is required for host and MSI initialization.
> 
> Fixes: 275e88b06a27 ("PCI: tegra: Fix host link initialization")
> Signed-off-by: Vidya Sagar <vidyas@...dia.com>
> ---
>  drivers/pci/controller/dwc/pcie-tegra194.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
> index 6fa216e52d14..4c3c0738f2e6 100644
> --- a/drivers/pci/controller/dwc/pcie-tegra194.c
> +++ b/drivers/pci/controller/dwc/pcie-tegra194.c
> @@ -2214,6 +2214,8 @@ static int tegra_pcie_dw_resume_noirq(struct device *dev)
>  		goto fail_host_init;
>  	}
>  
> +	dw_pcie_setup_rc(&pcie->pci.pp);
> +
>  	ret = tegra_pcie_dw_start_link(&pcie->pci);
>  	if (ret < 0)
>  		goto fail_host_init;
> 


Thanks for fixing!

Tested-by: Jon Hunter <jonathanh@...dia.com>

We should also mark this for stable so that this gets back-ported.

Jon

-- 
nvpublic