linux-kernel - Re: [PATCH] ARM: dts: gemini: rename to nand-controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdY43=Uh+EVSOPHqNgrhVfgpubZNtXRzO5nW335R6aJGbg@mail.gmail.com>
Date:   Thu, 6 May 2021 12:26:32 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Corentin Labbe <clabbe@...libre.com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Hans Ulli Kroll <ulli.kroll@...glemail.com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: dts: gemini: rename to nand-controller

On Wed, Apr 28, 2021 at 7:55 PM Corentin Labbe <clabbe@...libre.com> wrote:

> We must use nand-controller instead of flash.
>
> Signed-off-by: Corentin Labbe <clabbe@...libre.com>

Hm, this flash memory isn't NAND, it is just memory-mapped
NOR flash.

The example for CFI NOR flash in
Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
clearly uses the node name "flash@"

There is however a real NAND and serial flash memory
controller at 0x65000000, but I haven't seen a platform
that uses it.

The extra compatible string "cortina,gemini-flash"
turns on some Gemini-specific checks, but it
goes into the global system controller, not the NAND
controller, as the system controller confusingly have
some registers for detecting NOR memory config.
drivers/mtd/maps/physmap-gemini.c

Yours,
Linus Walleij