linux-kernel - Re: [PATCH] ib_srpt: Remove redundant assignment to ret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YJPUQkQCS86mS9gw@unreal>
Date:   Thu, 6 May 2021 14:34:26 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Yang Li <yang.lee@...ux.alibaba.com>
Cc:     bvanassche@....org, dledford@...hat.com, jgg@...pe.ca,
        nathan@...nel.org, ndesaulniers@...gle.com,
        linux-rdma@...r.kernel.org, target-devel@...r.kernel.org,
        linux-kernel@...r.kernel.org, clang-built-linux@...glegroups.com
Subject: Re: [PATCH] ib_srpt: Remove redundant assignment to ret

On Thu, May 06, 2021 at 06:15:05PM +0800, Yang Li wrote:
> Variable 'ret' is set to -ENOMEM but this value is never read as it is
> overwritten with a new value later on, hence it is a redundant
> assignment and can be removed
> 
> In 'commit b79fafac70fc ("target: make queue_tm_rsp() return void")'
> srpt_queue_response() has been changed to return void, so after "goto
> out", there is no need to return ret.
> 
> Clean up the following clang-analyzer warning:
> 
> drivers/infiniband/ulp/srpt/ib_srpt.c:2860:3: warning: Value stored to
> 'ret' is never read [clang-analyzer-deadcode.DeadStores]
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---
>  drivers/infiniband/ulp/srpt/ib_srpt.c | 1 -
>  1 file changed, 1 deletion(-)
> 

Fixes: b99f8e4d7bcd ("IB/srpt: convert to the generic RDMA READ/WRITE API") 

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...dia.com>