linux-kernel - Re: [PATCH] iio: bme680

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 6 May 2021 15:34:20 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Guenter Roeck <linux@...ck-us.net>,
        Jonathan Cameron <jic23@...nel.org>
Cc:     linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Andy Shevchenko <andy.shevchenko@...il.com>
Subject: Re: [PATCH] iio: bme680_spi: Remove ACPI support

Hi,

On 5/6/21 3:31 PM, Guenter Roeck wrote:
> BME0680 is not an official ACPI ID, so let's remove it before someone
> starts using it.
> 
> Cc: Andy Shevchenko <andy.shevchenko@...il.com>
> Cc: Hans de Goede <hdegoede@...hat.com>
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@...hat.com>

Regards,

Hans


> ---
>  drivers/iio/chemical/bme680_spi.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/iio/chemical/bme680_spi.c b/drivers/iio/chemical/bme680_spi.c
> index 6f56ad48cc40..cc579a7ac5ce 100644
> --- a/drivers/iio/chemical/bme680_spi.c
> +++ b/drivers/iio/chemical/bme680_spi.c
> @@ -4,7 +4,6 @@
>   *
>   * Copyright (C) 2018 Himanshu Jha <himanshujha199640@...il.com>
>   */
> -#include <linux/acpi.h>
>  #include <linux/module.h>
>  #include <linux/of.h>
>  #include <linux/regmap.h>
> @@ -145,12 +144,6 @@ static const struct spi_device_id bme680_spi_id[] = {
>  };
>  MODULE_DEVICE_TABLE(spi, bme680_spi_id);
>  
> -static const struct acpi_device_id bme680_acpi_match[] = {
> -	{"BME0680", 0},
> -	{},
> -};
> -MODULE_DEVICE_TABLE(acpi, bme680_acpi_match);
> -
>  static const struct of_device_id bme680_of_spi_match[] = {
>  	{ .compatible = "bosch,bme680", },
>  	{},
> @@ -160,7 +153,6 @@ MODULE_DEVICE_TABLE(of, bme680_of_spi_match);
>  static struct spi_driver bme680_spi_driver = {
>  	.driver = {
>  		.name			= "bme680_spi",
> -		.acpi_match_table	= ACPI_PTR(bme680_acpi_match),
>  		.of_match_table		= bme680_of_spi_match,
>  	},
>  	.probe = bme680_spi_probe,
>