linux-kernel - Re: [PATCH] dmaengine: idxd: Remove redundant variable cdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 6 May 2021 08:07:34 -0700
From:   Dave Jiang <dave.jiang@...el.com>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc:     vkoul@...nel.org, dmaengine@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dmaengine: idxd: Remove redundant variable cdev_ctx


On 5/6/2021 4:00 AM, Jiapeng Chong wrote:
> Variable cdev_ctx is set to '&ictx[wq->idxd->data->type]' but this
> value is not used, hence it is a redundant assignment and can be
> removed.
>
> Clean up the following clang-analyzer warning:
>
> drivers/dma/idxd/cdev.c:300:2: warning: Value stored to 'cdev_ctx' is
> never read [clang-analyzer-deadcode.DeadStores].
>
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>

Acked-by: Dave Jiang <dave.jiang@...el.com>

Thanks.


> ---
>   drivers/dma/idxd/cdev.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/dma/idxd/cdev.c b/drivers/dma/idxd/cdev.c
> index 302cba5..6c72089 100644
> --- a/drivers/dma/idxd/cdev.c
> +++ b/drivers/dma/idxd/cdev.c
> @@ -295,9 +295,7 @@ int idxd_wq_add_cdev(struct idxd_wq *wq)
>   void idxd_wq_del_cdev(struct idxd_wq *wq)
>   {
>   	struct idxd_cdev *idxd_cdev;
> -	struct idxd_cdev_context *cdev_ctx;
>   
> -	cdev_ctx = &ictx[wq->idxd->data->type];
>   	idxd_cdev = wq->idxd_cdev;
>   	wq->idxd_cdev = NULL;
>   	cdev_device_del(&idxd_cdev->cdev, &idxd_cdev->dev);