linux-kernel - RE: [PATCH v4 1/2] mm/memory-failure: Use a mutex to avoid memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e50bbef65855443ba2be457a703ba1a5@intel.com>
Date:   Thu, 6 May 2021 15:34:48 +0000
From:   "Luck, Tony" <tony.luck@...el.com>
To:     Aili Yao <yaoaili@...gsoft.com>,
        Naoya Horiguchi <nao.horiguchi@...il.com>
CC:     "linux-mm@...ck.org" <linux-mm@...ck.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Oscar Salvador <osalvador@...e.de>,
        "David Hildenbrand" <david@...hat.com>,
        Borislav Petkov <bp@...en8.de>,
        "Andy Lutomirski" <luto@...nel.org>,
        Naoya Horiguchi <naoya.horiguchi@....com>,
        Jue Wang <juew@...gle.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "yaoaili126@...il.com" <yaoaili126@...il.com>
Subject: RE: [PATCH v4 1/2] mm/memory-failure: Use a mutex to avoid
 memory_failure() races

> Sorry to interrupt, I just thought one thing:
>
> This mutex seems not been bind to the error page, will there be some core case
> like test code or multi-poison case whick will break this mutex?

The mutex is a bigger hammer than strictly needed . If there are simultaneous
errors on different pages they could, int theory, proceed in parallel. But this mutex
will serialize the processing.

Is this a problem? Hopefully systems aren't seeing so many uncorrectable/recoverable
errors that this would be a significant bottleneck.

-Tony