linux-kernel - Re: [PATCH] Input: ili210x - add missing negation for touch indication on ili210x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <a07a1804-28cd-bd07-f3cd-3307be433534@denx.de>
Date:   Thu, 6 May 2021 19:50:59 +0200
From:   Marek Vasut <marex@...x.de>
To:     Hansem Ro <hansemro@...look.com>, linux-input@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, dmitry.torokhov@...il.com
Subject: Re: [PATCH] Input: ili210x - add missing negation for touch
 indication on ili210x

On 5/6/21 7:32 PM, Hansem Ro wrote:
> This adds the negation needed for proper finger detection on Ilitek
> ili2107/ili210x. This fixes the polling and coordinate parsing issues
> (on Amazon Kindle Fire) caused by returning false for the cooresponding
> finger on the touchscreen.
> 
> Signed-off-by: Hansem Ro <hansemro@...look.com>
> ---
>   drivers/input/touchscreen/ili210x.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/touchscreen/ili210x.c b/drivers/input/touchscreen/ili210x.c
> index d8fccf048bf4..30576a5f2f04 100644
> --- a/drivers/input/touchscreen/ili210x.c
> +++ b/drivers/input/touchscreen/ili210x.c
> @@ -87,7 +87,7 @@ static bool ili210x_touchdata_to_coords(const u8 *touchdata,
>   					unsigned int *x, unsigned int *y,
>   					unsigned int *z)
>   {
> -	if (touchdata[0] & BIT(finger))
> +	if (!(touchdata[0] & BIT(finger)))

This makes the behavior consistent with the other ILI21xx touchscreen 
controllers too, so I think this patch is OK, thanks.

It would be nice if you could add Fixes: tag, so this could get picked 
into linux-stable too.