linux-kernel - Re: [PATCH v4 1/2] i2c: add binding to mark a bus as supporting SMBus-Alert

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210507005517.GA1098665@robh.at.kernel.org>
Date:   Thu, 6 May 2021 19:55:17 -0500
From:   Rob Herring <robh@...nel.org>
To:     Alain Volmat <alain.volmat@...s.st.com>
Cc:     wsa@...nel.org, mark.rutland@....com,
        pierre-yves.mordret@...s.st.com, mcoquelin.stm32@...il.com,
        alexandre.torgue@...s.st.com, linux-i2c@...r.kernel.org,
        devicetree@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        fabrice.gasnier@...s.st.com
Subject: Re: [PATCH v4 1/2] i2c: add binding to mark a bus as supporting
 SMBus-Alert

On Wed, May 05, 2021 at 03:14:38PM +0200, Alain Volmat wrote:
> Since SMBus-Alert is an optional feature of SMBUS which
> requires an additional pin, the smbus binding cannot be
> used to indicate its support.
> 
> Add an additional smbus-alert binding specific for it and
> update the description text of smbus to avoid mentioning
> SMBus-Alert
> 
> Signed-off-by: Alain Volmat <alain.volmat@...s.st.com>
> ---
>  Documentation/devicetree/bindings/i2c/i2c.txt | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)

This needs to be added to i2c-bus.yaml too.

Acked-by: Rob Herring <robh@...nel.org>

> 
> diff --git a/Documentation/devicetree/bindings/i2c/i2c.txt b/Documentation/devicetree/bindings/i2c/i2c.txt
> index df41f72afc87..b864916e087f 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c.txt
> @@ -89,8 +89,11 @@ wants to support one of the below features, it should adapt these bindings.
>  
>  - smbus
>  	states that additional SMBus restrictions and features apply to this bus.
> -	Examples of features are SMBusHostNotify and SMBusAlert. Examples of
> -	restrictions are more reserved addresses and timeout definitions.
> +	An example of feature is SMBusHostNotify. Examples of restrictions are
> +	more reserved addresses and timeout definitions.
> +
> +- smbus-alert
> +	states that the optional SMBus-Alert feature apply to this bus.
>  
>  Required properties (per child device)
>  --------------------------------------
> -- 
> 2.7.4
>