linux-kernel - Re: [PATCH] binder: Return EFAULT if we fail BINDER_ENABLE_ONEWAY_SPAM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210507071519.et56j3kqcxrhykqo@wittgenstein>
Date:   Fri, 7 May 2021 09:15:19 +0200
From:   Christian Brauner <christian.brauner@...ntu.com>
To:     Luca Stefani <luca.stefani.ge1@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Arve Hjønnevåg <arve@...roid.com>,
        Todd Kjos <tkjos@...roid.com>,
        Martijn Coenen <maco@...roid.com>,
        Joel Fernandes <joel@...lfernandes.org>,
        Christian Brauner <christian@...uner.io>,
        Hridya Valsaraju <hridya@...gle.com>,
        Suren Baghdasaryan <surenb@...gle.com>,
        Hang Lu <hangl@...eaurora.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] binder: Return EFAULT if we fail
 BINDER_ENABLE_ONEWAY_SPAM_DETECTION

On Thu, May 06, 2021 at 09:37:25PM +0200, Luca Stefani wrote:
> All the other ioctl paths return EFAULT in case the
> copy_from_user/copy_to_user call fails, make oneway spam detection
> follow the same paradigm.
> 
> Fixes: a7dc1e6f99df ("binder: tell userspace to dump current backtrace
> when detected oneway spamming")
> Signed-off-by: Luca Stefani <luca.stefani.ge1@...il.com>
> ---

Looks good,
Acked-by: Christian Brauner <christian.brauner@...ntu.com>