| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20210507011324.GA1119409@robh.at.kernel.org>
Date: Thu, 6 May 2021 20:13:24 -0500
From: Rob Herring <robh@...nel.org>
To: Steven Lee <steven_lee@...eedtech.com>
Cc: Andrew Jeffery <andrew@...id.au>,
Ulf Hansson <ulf.hansson@...aro.org>,
Joel Stanley <joel@....id.au>,
Adrian Hunter <adrian.hunter@...el.com>,
Philipp Zabel <p.zabel@...gutronix.de>,
Ryan Chen <ryanchen.aspeed@...il.com>,
"moderated list:ASPEED SD/MMC DRIVER" <linux-aspeed@...ts.ozlabs.org>,
"moderated list:ASPEED SD/MMC DRIVER" <openbmc@...ts.ozlabs.org>,
"open list:ASPEED SD/MMC DRIVER" <linux-mmc@...r.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@...r.kernel.org>,
"moderated list:ARM/ASPEED MACHINE SUPPORT"
<linux-arm-kernel@...ts.infradead.org>,
open list <linux-kernel@...r.kernel.org>, Hongweiz@....com,
ryan_chen@...eedtech.com, chin-ting_kuo@...eedtech.com
Subject: Re: [PATCH v3 1/5] dt-bindings: mmc: sdhci-of-aspeed: Add an example
for AST2600-A2 EVB
On Thu, May 06, 2021 at 06:03:08PM +0800, Steven Lee wrote:
> AST2600-A2 EVB has the reference design for enabling SD bus
> power and toggling SD bus signal voltage by GPIO pins.
>
> In the reference design, GPIOV0 of AST2600-A2 EVB is connected to
> power load switch that providing 3.3v to SD1 bus vdd. GPIOV1 is
> connected to a 1.8v and a 3.3v power load switch that providing
> signal voltage to
> SD1 bus.
>
> If GPIOV0 is active high, SD1 bus is enabled. Otherwise, SD1 bus is
> disabled.
> If GPIOV1 is active high, 3.3v power load switch is enabled, SD1
> signal voltage is 3.3v. Otherwise, 1.8v power load switch will be
> enabled, SD1 signal voltage becomes 1.8v.
>
> AST2600-A2 EVB also support toggling signal voltage for SD2 bus.
> The design is the same as SD1 bus. It uses GPIOV2 as power-gpio and
> GPIOV3 as power-switch-gpio.
>
> Signed-off-by: Steven Lee <steven_lee@...eedtech.com>
> ---
> .../devicetree/bindings/mmc/aspeed,sdhci.yaml | 101 +++++++++++++++++-
> 1 file changed, 97 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
> index 987b287f3bff..de7e61b3d37a 100644
> --- a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
> +++ b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
> @@ -45,10 +45,16 @@ patternProperties:
>
> properties:
> compatible:
> - enum:
> - - aspeed,ast2400-sdhci
> - - aspeed,ast2500-sdhci
> - - aspeed,ast2600-sdhci
> + oneOf:
> + - items:
> + - enum:
> + - aspeed,ast2400-sdhci
> + - aspeed,ast2500-sdhci
> + - aspeed,ast2600-sdhci
> + - items:
> + - enum:
> + - aspeed,ast2600-sdhci
> + - const: sdhci
Why are you adding 'sdhci'. That's not useful as a compatible given how
many quirks different implementations have.
> reg:
> maxItems: 1
> description: The SDHCI registers
> @@ -104,3 +110,90 @@ examples:
> clocks = <&syscon ASPEED_CLK_SDIO>;
> };
> };
> +
> + - |
Why do we need another example?
> + #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/clock/aspeed-clock.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + vcc_sdhci0: regulator-vcc-sdhci0 {
> + compatible = "regulator-fixed";
> + regulator-name = "SDHCI0 Vcc";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + gpios = <&gpio0 168
> + GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> + };
> +
> + vccq_sdhci0: regulator-vccq-sdhci0 {
> + compatible = "regulator-gpio";
> +
> + regulator-name = "SDHCI0 VccQ";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <3300000>;
> + gpios = <&gpio0 169
> + GPIO_ACTIVE_HIGH>;
> + gpios-states = <1>;
> + states = <3300000 1>,
> + <1800000 0>;
> + };
> +
> + vcc_sdhci1: regulator-vcc-sdhci1 {
> + compatible = "regulator-fixed";
> +
> + regulator-name = "SDHCI1 Vcc";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + gpios = <&gpio0 170
> + GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> + };
> +
> + vccq_sdhci1: regulator-vccq-sdhci1 {
> + compatible = "regulator-gpio";
> +
> + regulator-name = "SDHCI1 VccQ";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <3300000>;
> + gpios = <&gpio0 171
> + GPIO_ACTIVE_HIGH>;
> + gpios-states = <1>;
> + states = <3300000 1>,
> + <1800000 0>;
> + };
> +
> + sdc@...40000 {
> + compatible = "aspeed,ast2600-sd-controller";
> + reg = <0x1e740000 0x100>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0 0x1e740000 0x20000>;
> + clocks = <&syscon ASPEED_CLK_GATE_SDCLK>;
> +
> + sdhci@...40100 {
> + compatible = "aspeed,ast2600-sdhci","sdhci";
> + reg = <0x100 0x100>;
> + interrupts = <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>;
> + sdhci,auto-cmd12;
> + clocks = <&syscon ASPEED_CLK_SDIO>;
> + vmmc-supply = <&vcc_sdhci0>;
> + vqmmc-supply = <&vccq_sdhci0>;
> + sd-uhs-sdr104;
> + clk-phase-uhs-sdr104 = <180>, <180>;
> + };
> +
> + sdhci@...40200 {
> + compatible = "aspeed,ast2600-sdhci","sdhci";
> + reg = <0x200 0x100>;
> + interrupts = <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>;
> + sdhci,auto-cmd12;
> + clocks = <&syscon ASPEED_CLK_SDIO>;
> + vmmc-supply = <&vcc_sdhci1>;
> + vqmmc-supply = <&vccq_sdhci1>;
> + sd-uhs-sdr104;
> + clk-phase-uhs-sdr104 = <0>, <0>;
> + };
> + };
> +
> +...
> --
> 2.17.1
>
Powered by blists - more mailing lists