lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <202105071655.hiXgiBVU-lkp@intel.com>
Date:   Fri, 7 May 2021 16:09:08 +0800
From:   kernel test robot <lkp@...el.com>
To:     Mauro Carvalho Chehab <mchehab@...nel.org>
Cc:     kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
        linux-kernel@...r.kernel.org, linux-media@...r.kernel.org
Subject: drivers/media/test-drivers/vivid/vivid-core.c:1883:12: warning:
 stack frame size of 2816 bytes in function 'vivid_probe'

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   e48661230cc35b3d0f4367eddfc19f86463ab917
commit: fcaeb01929d7c4bfcaa2b374119d6a9a823d0dfe media: vivid: place the logic which disables ioctl on a separate function
date:   8 months ago
config: powerpc64-randconfig-r024-20210507 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project a3a8a1a15b524d91b5308db68e9d293b34cd88dd)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install powerpc64 cross compiling tool for clang build
        # apt-get install binutils-powerpc64-linux-gnu
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=fcaeb01929d7c4bfcaa2b374119d6a9a823d0dfe
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout fcaeb01929d7c4bfcaa2b374119d6a9a823d0dfe
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=powerpc64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   __do_insb
   ^
   arch/powerpc/include/asm/io.h:541:56: note: expanded from macro '__do_insb'
   #define __do_insb(p, b, n)      readsb((PCI_IO_ADDR)_IO_BASE+(p), (b), (n))
                                          ~~~~~~~~~~~~~~~~~~~~~^
   In file included from drivers/media/test-drivers/vivid/vivid-core.c:20:
   In file included from include/media/videobuf2-vmalloc.h:16:
   In file included from include/media/videobuf2-v4l2.h:16:
   In file included from include/media/videobuf2-core.h:18:
   In file included from include/linux/dma-buf.h:18:
   In file included from include/linux/scatterlist.h:9:
   In file included from arch/powerpc/include/asm/io.h:604:
   arch/powerpc/include/asm/io-defs.h:45:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
   DEF_PCI_AC_NORET(insw, (unsigned long p, void *b, unsigned long c),
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   arch/powerpc/include/asm/io.h:601:3: note: expanded from macro 'DEF_PCI_AC_NORET'
                   __do_##name al;                                 \
                   ^~~~~~~~~~~~~~
   <scratch space>:250:1: note: expanded from here
   __do_insw
   ^
   arch/powerpc/include/asm/io.h:542:56: note: expanded from macro '__do_insw'
   #define __do_insw(p, b, n)      readsw((PCI_IO_ADDR)_IO_BASE+(p), (b), (n))
                                          ~~~~~~~~~~~~~~~~~~~~~^
   In file included from drivers/media/test-drivers/vivid/vivid-core.c:20:
   In file included from include/media/videobuf2-vmalloc.h:16:
   In file included from include/media/videobuf2-v4l2.h:16:
   In file included from include/media/videobuf2-core.h:18:
   In file included from include/linux/dma-buf.h:18:
   In file included from include/linux/scatterlist.h:9:
   In file included from arch/powerpc/include/asm/io.h:604:
   arch/powerpc/include/asm/io-defs.h:47:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
   DEF_PCI_AC_NORET(insl, (unsigned long p, void *b, unsigned long c),
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   arch/powerpc/include/asm/io.h:601:3: note: expanded from macro 'DEF_PCI_AC_NORET'
                   __do_##name al;                                 \
                   ^~~~~~~~~~~~~~
   <scratch space>:5:1: note: expanded from here
   __do_insl
   ^
   arch/powerpc/include/asm/io.h:543:56: note: expanded from macro '__do_insl'
   #define __do_insl(p, b, n)      readsl((PCI_IO_ADDR)_IO_BASE+(p), (b), (n))
                                          ~~~~~~~~~~~~~~~~~~~~~^
   In file included from drivers/media/test-drivers/vivid/vivid-core.c:20:
   In file included from include/media/videobuf2-vmalloc.h:16:
   In file included from include/media/videobuf2-v4l2.h:16:
   In file included from include/media/videobuf2-core.h:18:
   In file included from include/linux/dma-buf.h:18:
   In file included from include/linux/scatterlist.h:9:
   In file included from arch/powerpc/include/asm/io.h:604:
   arch/powerpc/include/asm/io-defs.h:49:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
   DEF_PCI_AC_NORET(outsb, (unsigned long p, const void *b, unsigned long c),
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   arch/powerpc/include/asm/io.h:601:3: note: expanded from macro 'DEF_PCI_AC_NORET'
                   __do_##name al;                                 \
                   ^~~~~~~~~~~~~~
   <scratch space>:10:1: note: expanded from here
   __do_outsb
   ^
   arch/powerpc/include/asm/io.h:544:58: note: expanded from macro '__do_outsb'
   #define __do_outsb(p, b, n)     writesb((PCI_IO_ADDR)_IO_BASE+(p),(b),(n))
                                           ~~~~~~~~~~~~~~~~~~~~~^
   In file included from drivers/media/test-drivers/vivid/vivid-core.c:20:
   In file included from include/media/videobuf2-vmalloc.h:16:
   In file included from include/media/videobuf2-v4l2.h:16:
   In file included from include/media/videobuf2-core.h:18:
   In file included from include/linux/dma-buf.h:18:
   In file included from include/linux/scatterlist.h:9:
   In file included from arch/powerpc/include/asm/io.h:604:
   arch/powerpc/include/asm/io-defs.h:51:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
   DEF_PCI_AC_NORET(outsw, (unsigned long p, const void *b, unsigned long c),
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   arch/powerpc/include/asm/io.h:601:3: note: expanded from macro 'DEF_PCI_AC_NORET'
                   __do_##name al;                                 \
                   ^~~~~~~~~~~~~~
   <scratch space>:15:1: note: expanded from here
   __do_outsw
   ^
   arch/powerpc/include/asm/io.h:545:58: note: expanded from macro '__do_outsw'
   #define __do_outsw(p, b, n)     writesw((PCI_IO_ADDR)_IO_BASE+(p),(b),(n))
                                           ~~~~~~~~~~~~~~~~~~~~~^
   In file included from drivers/media/test-drivers/vivid/vivid-core.c:20:
   In file included from include/media/videobuf2-vmalloc.h:16:
   In file included from include/media/videobuf2-v4l2.h:16:
   In file included from include/media/videobuf2-core.h:18:
   In file included from include/linux/dma-buf.h:18:
   In file included from include/linux/scatterlist.h:9:
   In file included from arch/powerpc/include/asm/io.h:604:
   arch/powerpc/include/asm/io-defs.h:53:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
   DEF_PCI_AC_NORET(outsl, (unsigned long p, const void *b, unsigned long c),
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   arch/powerpc/include/asm/io.h:601:3: note: expanded from macro 'DEF_PCI_AC_NORET'
                   __do_##name al;                                 \
                   ^~~~~~~~~~~~~~
   <scratch space>:20:1: note: expanded from here
   __do_outsl
   ^
   arch/powerpc/include/asm/io.h:546:58: note: expanded from macro '__do_outsl'
   #define __do_outsl(p, b, n)     writesl((PCI_IO_ADDR)_IO_BASE+(p),(b),(n))
                                           ~~~~~~~~~~~~~~~~~~~~~^
>> drivers/media/test-drivers/vivid/vivid-core.c:1883:12: warning: stack frame size of 2816 bytes in function 'vivid_probe' [-Wframe-larger-than=]
   static int vivid_probe(struct platform_device *pdev)
              ^
   13 warnings generated.


vim +/vivid_probe +1883 drivers/media/test-drivers/vivid/vivid-core.c

c88a96b023d8239 drivers/media/platform/vivid/vivid-core.c Hans Verkuil 2014-08-25  1878  
c88a96b023d8239 drivers/media/platform/vivid/vivid-core.c Hans Verkuil 2014-08-25  1879     The real maximum number of virtual drivers will depend on how many drivers
c88a96b023d8239 drivers/media/platform/vivid/vivid-core.c Hans Verkuil 2014-08-25  1880     will succeed. This is limited to the maximum number of devices that
c88a96b023d8239 drivers/media/platform/vivid/vivid-core.c Hans Verkuil 2014-08-25  1881     videodev supports, which is equal to VIDEO_NUM_DEVICES.
c88a96b023d8239 drivers/media/platform/vivid/vivid-core.c Hans Verkuil 2014-08-25  1882   */
f46d740fb025898 drivers/media/platform/vivid/vivid-core.c Hans Verkuil 2015-03-13 @1883  static int vivid_probe(struct platform_device *pdev)
c88a96b023d8239 drivers/media/platform/vivid/vivid-core.c Hans Verkuil 2014-08-25  1884  {
c88a96b023d8239 drivers/media/platform/vivid/vivid-core.c Hans Verkuil 2014-08-25  1885  	const struct font_desc *font = find_font("VGA8x16");
c88a96b023d8239 drivers/media/platform/vivid/vivid-core.c Hans Verkuil 2014-08-25  1886  	int ret = 0, i;
c88a96b023d8239 drivers/media/platform/vivid/vivid-core.c Hans Verkuil 2014-08-25  1887  
c88a96b023d8239 drivers/media/platform/vivid/vivid-core.c Hans Verkuil 2014-08-25  1888  	if (font == NULL) {
c88a96b023d8239 drivers/media/platform/vivid/vivid-core.c Hans Verkuil 2014-08-25  1889  		pr_err("vivid: could not find font\n");
c88a96b023d8239 drivers/media/platform/vivid/vivid-core.c Hans Verkuil 2014-08-25  1890  		return -ENODEV;
c88a96b023d8239 drivers/media/platform/vivid/vivid-core.c Hans Verkuil 2014-08-25  1891  	}
c88a96b023d8239 drivers/media/platform/vivid/vivid-core.c Hans Verkuil 2014-08-25  1892  
c88a96b023d8239 drivers/media/platform/vivid/vivid-core.c Hans Verkuil 2014-08-25  1893  	tpg_set_font(font->data);
c88a96b023d8239 drivers/media/platform/vivid/vivid-core.c Hans Verkuil 2014-08-25  1894  
c88a96b023d8239 drivers/media/platform/vivid/vivid-core.c Hans Verkuil 2014-08-25  1895  	n_devs = clamp_t(unsigned, n_devs, 1, VIVID_MAX_DEVS);
c88a96b023d8239 drivers/media/platform/vivid/vivid-core.c Hans Verkuil 2014-08-25  1896  
c88a96b023d8239 drivers/media/platform/vivid/vivid-core.c Hans Verkuil 2014-08-25  1897  	for (i = 0; i < n_devs; i++) {
f46d740fb025898 drivers/media/platform/vivid/vivid-core.c Hans Verkuil 2015-03-13  1898  		ret = vivid_create_instance(pdev, i);
c88a96b023d8239 drivers/media/platform/vivid/vivid-core.c Hans Verkuil 2014-08-25  1899  		if (ret) {
c88a96b023d8239 drivers/media/platform/vivid/vivid-core.c Hans Verkuil 2014-08-25  1900  			/* If some instantiations succeeded, keep driver */
c88a96b023d8239 drivers/media/platform/vivid/vivid-core.c Hans Verkuil 2014-08-25  1901  			if (i)
c88a96b023d8239 drivers/media/platform/vivid/vivid-core.c Hans Verkuil 2014-08-25  1902  				ret = 0;
c88a96b023d8239 drivers/media/platform/vivid/vivid-core.c Hans Verkuil 2014-08-25  1903  			break;
c88a96b023d8239 drivers/media/platform/vivid/vivid-core.c Hans Verkuil 2014-08-25  1904  		}
c88a96b023d8239 drivers/media/platform/vivid/vivid-core.c Hans Verkuil 2014-08-25  1905  	}
c88a96b023d8239 drivers/media/platform/vivid/vivid-core.c Hans Verkuil 2014-08-25  1906  
c88a96b023d8239 drivers/media/platform/vivid/vivid-core.c Hans Verkuil 2014-08-25  1907  	if (ret < 0) {
c88a96b023d8239 drivers/media/platform/vivid/vivid-core.c Hans Verkuil 2014-08-25  1908  		pr_err("vivid: error %d while loading driver\n", ret);
c88a96b023d8239 drivers/media/platform/vivid/vivid-core.c Hans Verkuil 2014-08-25  1909  		return ret;
c88a96b023d8239 drivers/media/platform/vivid/vivid-core.c Hans Verkuil 2014-08-25  1910  	}
c88a96b023d8239 drivers/media/platform/vivid/vivid-core.c Hans Verkuil 2014-08-25  1911  
c88a96b023d8239 drivers/media/platform/vivid/vivid-core.c Hans Verkuil 2014-08-25  1912  	/* n_devs will reflect the actual number of allocated devices */
c88a96b023d8239 drivers/media/platform/vivid/vivid-core.c Hans Verkuil 2014-08-25  1913  	n_devs = i;
c88a96b023d8239 drivers/media/platform/vivid/vivid-core.c Hans Verkuil 2014-08-25  1914  
c88a96b023d8239 drivers/media/platform/vivid/vivid-core.c Hans Verkuil 2014-08-25  1915  	return ret;
c88a96b023d8239 drivers/media/platform/vivid/vivid-core.c Hans Verkuil 2014-08-25  1916  }
c88a96b023d8239 drivers/media/platform/vivid/vivid-core.c Hans Verkuil 2014-08-25  1917  

:::::: The code at line 1883 was first introduced by commit
:::::: f46d740fb0258982f00ffdbddc6486e674edafb5 [media] vivid: turn this into a platform_device

:::::: TO: Hans Verkuil <hans.verkuil@...co.com>
:::::: CC: Mauro Carvalho Chehab <mchehab@....samsung.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (25745 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ