linux-kernel - RE: [PATCH v3] HID: i2c-hid: Skip ELAN power-on command after reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <038a01d7431d$3adb6b90$b09242b0$@emc.com.tw>
Date:   Fri, 7 May 2021 16:44:44 +0800
From:   "Johnny.Chuang" <johnny.chuang@....com.tw>
To:     "'Doug Anderson'" <dianders@...omium.org>,
        "'Johnny Chuang'" <johnny.chuang.emc@...il.com>
Cc:     "'Dmitry Torokhov'" <dmitry.torokhov@...il.com>,
        "'Benjamin Tissoires'" <benjamin.tissoires@...hat.com>,
        "'Peter Hutterer'" <peter.hutterer@...-t.net>,
        "'LKML'" <linux-kernel@...r.kernel.org>,
        "'open list:HID CORE LAYER'" <linux-input@...r.kernel.org>,
        "'Harry Cutts'" <hcutts@...omium.org>,
        "'James Chen'" <james.chen@....com.tw>,
        "'Jennifer Tsai'" <jennifer.tsai@....com.tw>,
        "'Paul Liang'" <paul.liang@....com.tw>,
        "'Jeff Chuang'" <jeff.chuang@....com.tw>,
        "'Jingle'" <jingle.wu@....com.tw>
Subject: RE: [PATCH v3] HID: i2c-hid: Skip ELAN power-on command after reset

> > Hi,
> >
> > On Mon, Apr 12, 2021 at 6:20 PM Johnny Chuang
> > <johnny.chuang.emc@...il.com> wrote:
> > >
> > > Fixes: 43b7029f475e ("HID: i2c-hid: Send power-on command after reset").
> >
> > Note that the "Fixes" tag actually belongs down at the end. It also
> > shouldn't have a "." at the end. Presumably the maintainer can adjust this
> when landing?
> >
> 
> Hi Dmitry,
> Could you help to review this patch and give an advice?

Hi Sirs,
Could anyone help to review this patch and give an advice?

> 
> >
> > > For ELAN touchscreen, we found our boot code of IC was not flexible
> > > enough to receive and handle this command.
> > > Once the FW main code of our controller is crashed for some reason,
> > > the controller could not be enumerated successfully to be recognized
> > > by the system host. therefore, it lost touch functionality.
> > >
> > > Add quirk for skip send power-on command after reset.
> > > It will impact to ELAN touchscreen and touchpad on HID over I2C projects.
> > >
> > > Signed-off-by: Johnny Chuang <johnny.chuang.emc@...il.com>
> >
> > This patch looks fine to me, thus:
> >
> > Reviewed-by: Douglas Anderson <dianders@...omium.org>
> >
> > I can confirm that after applying this patch I can recovery my borked
> > touchscreen (which got borked by a failed firmware update ages ago):
> >
> > Tested-by: Douglas Anderson <dianders@...omium.org>