linux-kernel - Re: [RESEND PATCH v11 0/3] AX88796C SPI Ethernet Adapter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210506170157.6deb1b6d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 6 May 2021 17:01:57 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Łukasz Stelmach <l.stelmach@...sung.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Andrew Lunn <andrew@...n.ch>, jim.cromie@...il.com,
        Heiner Kallweit <hkallweit1@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Kukjin Kim <kgene@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Russell King <linux@...linux.org.uk>, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org,
        Bartłomiej Żolnierkiewicz 
        <b.zolnierkie@...sung.com>,
        Marek Szyprowski <m.szyprowski@...sung.com>
Subject: Re: [RESEND PATCH v11 0/3] AX88796C SPI Ethernet Adapter

On Wed, 05 May 2021 19:11:39 +0200 Łukasz Stelmach wrote:
> It was <2021-03-02 wto 16:22>, when Łukasz Stelmach wrote:
> > This is a driver for AX88796C Ethernet Adapter connected in SPI mode as
> > found on ARTIK5 evaluation board. The driver has been ported from a
> > v3.10.9 vendor kernel for ARTIK5 board.
> >
> > Changes in v11:
> >   - changed stat counters to 64-bit
> >   - replaced WARN_ON(!mutex_is_locked()) with lockdep_assert_held()
> >   - replaced ax88796c_free_skb_queue() with __skb_queue_purge()
> >   - added cancel_work_sync() for ax_work
> >   - removed unused fields of struct skb_data
> >   - replaced MAX() with max() from minmax.h
> >   - rebased to net-next (resend)  
> 
> Hi,
> 
> What is current status? Should I rebase once more?

Unfortunately it seems so :( The patches got marked as Not Applicable
in patchwork. And now we are once again in the merge window period.
Please repost late next week, and make sure to prefix the subjects with
[PATCH net-next v12], this will hopefully prevent mis-categorization.

Looking at the code again is the use of netif_stop_queue(ndev) in
ax88796c_close() not a little racy? The work may be running in parallel 
and immediately re-enable the queue.