Date:   Fri, 7 May 2021 11:11:35 +0200
From:   Maxime Coquelin <maxime.coquelin@...hat.com>
To:     Ondrej Mosnacek <omosnace@...hat.com>,
        Alex Williamson <alex.williamson@...hat.com>
Cc:     James Morris <jmorris@...ei.org>,
        David Howells <dhowells@...hat.com>,
        Linux kernel mailing list <linux-kernel@...r.kernel.org>,
        Linux Security Module list 
        <linux-security-module@...r.kernel.org>, kvm@...r.kernel.org,
        mjg59@...f.ucam.org, Kees Cook <keescook@...omium.org>,
        Cornelia Huck <cohuck@...hat.com>
Subject: Re: [PATCH] vfio: Lock down no-IOMMU mode when kernel is locked down



On 5/7/21 10:37 AM, Ondrej Mosnacek wrote:
> On Thu, May 6, 2021 at 11:50 PM Alex Williamson
> <alex.williamson@...hat.com> wrote:
>> On Thu,  6 May 2021 11:18:59 +0200
>> Maxime Coquelin <maxime.coquelin@...hat.com> wrote:
>>
>>> When no-IOMMU mode is enabled, VFIO is as unsafe as accessing
>>> the PCI BARs via the device's sysfs, which is locked down when
>>> the kernel is locked down.
>>>
>>> Indeed, it is possible for an attacker to craft DMA requests
>>> to modify kernel's code or leak secrets stored in the kernel,
>>> since the device is not isolated by an IOMMU.
>>>
>>> This patch introduces a new integrity lockdown reason for the
>>> unsafe VFIO no-iommu mode.
>>
>> I'm hoping security folks will chime in here as I'm not familiar with
>> the standard practices for new lockdown reasons.  The vfio no-iommu
>> backend is clearly an integrity risk, which is why it's already hidden
>> behind a separate Kconfig option, requires RAWIO capabilities, and
>> taints the kernel if it's used, but I agree that preventing it during
>> lockdown seems like a good additional step.
>>
>> Is it generally advised to create specific reasons, like done here, or
>> should we aim to create a more generic reason related to unrestricted
>> userspace DMA?

I am fine with a more generic reason. I'm also not sure what is the best
thing to do in term of granularity.

>> I understand we don't want to re-use PCI_ACCESS because the vfio
>> no-iommu backend is device agnostic, it can be used for both PCI and
>> non-PCI devices.

Right, that's why I created a new reason.

>>> Signed-off-by: Maxime Coquelin <maxime.coquelin@...hat.com>
>>> ---
>>>  drivers/vfio/vfio.c      | 13 +++++++++----
>>>  include/linux/security.h |  1 +
>>>  security/security.c      |  1 +
>>>  3 files changed, 11 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/drivers/vfio/vfio.c b/drivers/vfio/vfio.c
>>> index 5e631c359ef2..fe466d6ea5d8 100644
>>> --- a/drivers/vfio/vfio.c
>>> +++ b/drivers/vfio/vfio.c
>>> @@ -25,6 +25,7 @@
>>>  #include <linux/pci.h>
>>>  #include <linux/rwsem.h>
>>>  #include <linux/sched.h>
>>> +#include <linux/security.h>
>>>  #include <linux/slab.h>
>>>  #include <linux/stat.h>
>>>  #include <linux/string.h>
>>> @@ -165,7 +166,8 @@ static void *vfio_noiommu_open(unsigned long arg)
>>>  {
>>>       if (arg != VFIO_NOIOMMU_IOMMU)
>>>               return ERR_PTR(-EINVAL);
>>> -     if (!capable(CAP_SYS_RAWIO))
>>> +     if (!capable(CAP_SYS_RAWIO) ||
>>> +                     security_locked_down(LOCKDOWN_VFIO_NOIOMMU))
>>>               return ERR_PTR(-EPERM);
>>>
>>>       return NULL;
>>> @@ -1280,7 +1282,8 @@ static int vfio_group_set_container(struct vfio_group *group, int container_fd)
>>>       if (atomic_read(&group->container_users))
>>>               return -EINVAL;
>>>
>>> -     if (group->noiommu && !capable(CAP_SYS_RAWIO))
>>> +     if (group->noiommu && (!capable(CAP_SYS_RAWIO) ||
>>> +                     security_locked_down(LOCKDOWN_VFIO_NOIOMMU)))
>>>               return -EPERM;
>>>
>>>       f = fdget(container_fd);
>>> @@ -1362,7 +1365,8 @@ static int vfio_group_get_device_fd(struct vfio_group *group, char *buf)
>>>           !group->container->iommu_driver || !vfio_group_viable(group))
>>>               return -EINVAL;
>>>
>>> -     if (group->noiommu && !capable(CAP_SYS_RAWIO))
>>> +     if (group->noiommu && (!capable(CAP_SYS_RAWIO) ||
>>> +                     security_locked_down(LOCKDOWN_VFIO_NOIOMMU)))
>>>               return -EPERM;
>>>
>>>       device = vfio_device_get_from_name(group, buf);
>>> @@ -1490,7 +1494,8 @@ static int vfio_group_fops_open(struct inode *inode, struct file *filep)
>>>       if (!group)
>>>               return -ENODEV;
>>>
>>> -     if (group->noiommu && !capable(CAP_SYS_RAWIO)) {
>>> +     if (group->noiommu && (!capable(CAP_SYS_RAWIO) ||
>>> +                     security_locked_down(LOCKDOWN_VFIO_NOIOMMU))) {
>>>               vfio_group_put(group);
>>>               return -EPERM;
>>>       }
>>
>> In these cases where we're testing RAWIO, the idea is to raise the
>> barrier of passing file descriptors to unprivileged users.  Is lockdown
>> sufficiently static that we might really only need the test on open?
>> The latter three cases here only make sense if the user were able to
>> open a no-iommu context when lockdown is not enabled, then lockdown is
>> later enabled preventing them from doing anything with that context...
>> but not preventing ongoing unsafe usage that might already exist.  I
>> suspect for that reason that lockdown is static and we really only need
>> the test on open.  Thanks,
> 
> Note that SELinux now also implements the locked_down hook and that
> implementation is not static like the Lockdown LSM's. It checks
> whether the current task's SELinux domain has either integrity or
> confidentiality permission granted by the policy, so for SELinux it
> makes sense to have the lockdown hook called in these other places as
> well.
> 

Thanks Ondrej for the insights, is there any plan for selinux to support
finer granularity than integrity and confidentiality? I'm not sure it
makes sense, but it might help to understand if we should choose between
a "VFIO no-iommu mode" reason and a more generic userspace DMA one.

Maxime

Powered by blists - more mailing lists