linux-kernel - Re: [PATCH 14/42] PCI: aardvark: Don't mask irq when mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87eeeiq4rc.wl-maz@kernel.org>
Date:   Fri, 07 May 2021 10:20:39 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     Pali Rohár <pali@...nel.org>
Cc:     Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        Rob Herring <robh@...nel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Russell King <rmk+kernel@...linux.org.uk>,
        Marek Behún <kabel@...nel.org>,
        Remi Pommarel <repk@...plefau.lt>, Xogium <contact@...ium.me>,
        Tomasz Maciej Nowak <tmn505@...il.com>,
        linux-pci@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 14/42] PCI: aardvark: Don't mask irq when mapping

On Thu, 06 May 2021 16:31:25 +0100,
Pali Rohár <pali@...nel.org> wrote:
> 
> By default, all Legacy INTx interrupts are masked, so there is no need to
> mask this interrupt during irq_map callback.

What guarantees that they are actually masked? I would actually assume
that the HW is in an unknown state at boot time.

Thanks,

	M.

> 
> Signed-off-by: Pali Rohár <pali@...nel.org>
> Reviewed-by: Marek Behún <kabel@...nel.org>
> ---
>  drivers/pci/controller/pci-aardvark.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controller/pci-aardvark.c
> index 2aced8c9ae9f..08f1157e1c5e 100644
> --- a/drivers/pci/controller/pci-aardvark.c
> +++ b/drivers/pci/controller/pci-aardvark.c
> @@ -940,7 +940,6 @@ static int advk_pcie_irq_map(struct irq_domain *h,
>  {
>  	struct advk_pcie *pcie = h->host_data;
>  
> -	advk_pcie_irq_mask(irq_get_irq_data(virq));
>  	irq_set_status_flags(virq, IRQ_LEVEL);
>  	irq_set_chip_and_handler(virq, &pcie->irq_chip,
>  				 handle_level_irq);
> -- 
> 2.20.1
> 
> 

-- 
Without deviation from the norm, progress is not possible.