linux-kernel - Re: [PATCH v2 1/3] usb: xhci-mtk: use bitfield instead of bool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1620350884.10796.4.camel@mhfsdcap03>
Date:   Fri, 7 May 2021 09:28:04 +0800
From:   Chunfeng Yun <chunfeng.yun@...iatek.com>
To:     Sergei Shtylyov <sergei.shtylyov@...il.com>
CC:     Mathias Nyman <mathias.nyman@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        <linux-usb@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-mediatek@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, "Ikjoon Jang" <ikjn@...omium.org>,
        Eddie Hung <eddie.hung@...iatek.com>
Subject: Re: [PATCH v2 1/3] usb: xhci-mtk: use bitfield instead of bool

On Thu, 2021-05-06 at 11:50 +0300, Sergei Shtylyov wrote:
> Hello!
> 
> On 06.05.2021 9:31, Chunfeng Yun wrote:
> 
> > Use bitfield instead of bool in struct
> > 
> > Refer to coding-style.rst 17) Using bool:
> > "If a structure has many true/false values, consider consolidating
> > them into a bitfield with 1 bit members, or using an appropriate
> > fixed width type, such as u8."
> > 
> > Due to @has_ippc's default vaule is 0, no need set it again if fail
> 
>     Value. :-)
Will fix it, thanks
> 
> > to get ippc base address
> > 
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@...iatek.com>
> [...]
> 
> MBR, Sergei