[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CWXP265MB2680A8DD0FFA6FECBFDFB027C4579@CWXP265MB2680.GBRP265.PROD.OUTLOOK.COM>
Date: Fri, 7 May 2021 10:34:33 +0000
From: Christian Löhle <CLoehle@...erstone.com>
To: Avri Altman <Avri.Altman@....com>,
"ulf.hansson@...aro.org" <ulf.hansson@...aro.org>,
"adrian.hunter@...el.com" <adrian.hunter@...el.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
Christian Löhle <CLoehle@...erstone.com>
CC: "axboe@...nel.dk" <axboe@...nel.dk>,
"zliua@...ron.com" <zliua@...ron.com>
Subject: [PATCH v2] mmc: block: ioctl: No busywaiting of non-TRAN CMDs
Prevent busywaiting for TRAN state indication
after issuing a command that will not transition
to TRAN state.
Signed-off-by: Christian Loehle <cloehle@...erstone.com>
---
drivers/mmc/core/block.c | 17 ++++++++++++++++-
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c
index 689eb9afeeed..48be2ca5e3d1 100644
--- a/drivers/mmc/core/block.c
+++ b/drivers/mmc/core/block.c
@@ -446,6 +446,20 @@ static int card_busy_detect(struct mmc_card *card, unsigned int timeout_ms,
return err;
}
+static inline bool is_tran_transition_cmd(struct mmc_command *cmd,
+ struct mmc_card *card)
+{
+ /* Cards will not be in TRAN after completing identification commands
+ * or MMC_SEND_STATUS if they are not selected.
+ */
+ return !(cmd->opcode == MMC_SEND_CID
+ || cmd->opcode == MMC_ALL_SEND_CID
+ || cmd->opcode == MMC_SEND_CSD
+ || (cmd->opcode == MMC_SEND_STATUS &&
+ MMC_EXTRACT_INDEX_FROM_ARG(cmd->arg) != card->rca));
+
+}
+
static int __mmc_blk_ioctl_cmd(struct mmc_card *card, struct mmc_blk_data *md,
struct mmc_blk_ioc_data *idata)
{
@@ -593,7 +607,8 @@ static int __mmc_blk_ioctl_cmd(struct mmc_card *card, struct mmc_blk_data *md,
memcpy(&(idata->ic.response), cmd.resp, sizeof(cmd.resp));
- if (idata->rpmb || (cmd.flags & MMC_RSP_R1B) == MMC_RSP_R1B) {
+ if ((idata->rpmb || (cmd.flags & MMC_RSP_R1B))
+ && is_tran_transition_cmd(&cmd, card)) {
/*
* Ensure RPMB/R1B command has completed by polling CMD13
* "Send Status".
--
2.31.1
Hyperstone GmbH | Line-Eid-Strasse 3 | 78467 Konstanz
Managing Directors: Dr. Jan Peter Berns.
Commercial register of local courts: Freiburg HRB381782
Powered by blists - more mailing lists