linux-kernel - Re: [PATCH AUTOSEL 5.12 16/79] usb: dwc3: gadget: Remove invalid low-speed setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YJUaqq0ZMVn2989b@sashalap>
Date:   Fri, 7 May 2021 06:47:06 -0400
From:   Sasha Levin <sashal@...nel.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 5.12 16/79] usb: dwc3: gadget: Remove invalid
 low-speed setting

On Sun, May 02, 2021 at 04:56:11PM +0200, Greg Kroah-Hartman wrote:
>On Sun, May 02, 2021 at 10:02:13AM -0400, Sasha Levin wrote:
>> From: Thinh Nguyen <Thinh.Nguyen@...opsys.com>
>>
>> [ Upstream commit 0c59f678fcfc6dd53ba493915794636a230bc4cc ]
>>
>> None of the DWC_usb3x IPs (and all their versions) supports low-speed
>> setting in device mode. In the early days, our "Early Adopter Edition"
>> DWC_usb3 databook shows that the controller may be configured to operate
>> in low-speed, but it was revised on release. Let's remove this invalid
>> speed setting to avoid any confusion.
>>
>> Signed-off-by: Thinh Nguyen <Thinh.Nguyen@...opsys.com>
>> Link: https://lore.kernel.org/r/258b1c7fbb966454f4c4c2c1367508998498fc30.1615509438.git.Thinh.Nguyen@synopsys.com
>> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>> Signed-off-by: Sasha Levin <sashal@...nel.org>
>> ---
>>  drivers/usb/dwc3/core.c   | 1 -
>>  drivers/usb/dwc3/core.h   | 2 --
>>  drivers/usb/dwc3/gadget.c | 8 --------
>>  3 files changed, 11 deletions(-)
>
>This is a "cleanup only" and does not fix or solve anything, so it can
>be dropped from all of the kernels it has been "autoselected" for.

Dropped, thanks!

-- 
Thanks,
Sasha