linux-kernel - Re: [PATCH] serial: 8250_pci: Use fallthrough pseudo-keyword

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YJU+uJcJ6Y+2PEUc@kroah.com>
Date:   Fri, 7 May 2021 15:20:56 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Wei Ming Chen <jj251510319013@...il.com>
Cc:     linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH] serial: 8250_pci: Use fallthrough pseudo-keyword

On Fri, May 07, 2021 at 09:04:03PM +0800, Wei Ming Chen wrote:
> Add pseudo-keyword macro fallthrough[1]
> 
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
> 
> Signed-off-by: Wei Ming Chen <jj251510319013@...il.com>
> ---
>  drivers/tty/serial/8250/8250_pci.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c
> index 689d8227f95f..4158f06de4d5 100644
> --- a/drivers/tty/serial/8250/8250_pci.c
> +++ b/drivers/tty/serial/8250/8250_pci.c
> @@ -847,8 +847,11 @@ static int pci_netmos_init(struct pci_dev *dev)
>  
>  	switch (dev->device) { /* FALLTHROUGH on all */
>  	case PCI_DEVICE_ID_NETMOS_9904:
> +		fallthrough;
>  	case PCI_DEVICE_ID_NETMOS_9912:
> +		fallthrough;
>  	case PCI_DEVICE_ID_NETMOS_9922:
> +		fallthrough;
>  	case PCI_DEVICE_ID_NETMOS_9900:

I really doubt this is needed here.  If so, something is really wrong
with the static checkers.

thanks,

greg k-h