linux-kernel - Re: [PATCH v2] dt-bindings: i2c: Move i2c-omap.txt to YAML format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210507163602.219894f4@aktux>
Date:   Fri, 7 May 2021 16:36:02 +0200
From:   Andreas Kemnade <andreas@...nade.info>
To:     Vignesh Raghavendra <vigneshr@...com>
Cc:     Grygorii Strashko <grygorii.strashko@...com>,
        Rob Herring <robh+dt@...nel.org>, <linux-omap@...r.kernel.org>,
        <linux-i2c@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        Linux ARM Mailing List <linux-arm-kernel@...ts.infradead.org>,
        Tony Lindgren <tony@...mide.com>, Nishanth Menon <nm@...com>
Subject: Re: [PATCH v2] dt-bindings: i2c: Move i2c-omap.txt to YAML format

On Fri, 7 May 2021 19:45:45 +0530
Vignesh Raghavendra <vigneshr@...com> wrote:

> On 5/7/21 12:24 PM, Grygorii Strashko wrote:
> > 
> > 
> > On 06/05/2021 17:00, Vignesh Raghavendra wrote:  
> >> Convert i2c-omap.txt to YAML schema for better checks and documentation.
> >>
> >> Following properties were used in DT but were not documented in txt
> >> bindings and has been included in YAML schema:
> >> 1. Include ti,am4372-i2c compatible
> >> 2. Include dmas property used in few OMAP dts files  
> > 
> > The DMA is not supported by i2c-omap driver, so wouldn't be better to
> > just drop dmas from DTBs to avoid confusions?
> > It can be added later.
> >   
> 
> Will do.. I will also send patches dropping dmas from dts that currently
> have them populated.
> 
hmm, we have
- DO attempt to make bindings complete even if a driver doesn't support some
  features. For example, if a device has an interrupt, then include the
  'interrupts' property even if the driver is only polled mode.

in Documentation/devicetree/bindings/writing-bindings.rst
Shouln't the dma stay there if the hardware supports it? Devicetree
should describe the hardware not the driver if I understood things
right.

Regards,
Andreas