linux-kernel - Re: [PATCH] usb: dwc3: gadget: Return success always for kick transfer in ep queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bb9d37e3-dce4-7b71-4dcd-97e2916be7de@codeaurora.org>
Date:   Fri, 7 May 2021 10:38:48 -0700
From:   Wesley Cheng <wcheng@...eaurora.org>
To:     Felipe Balbi <balbi@...nel.org>, gregkh@...uxfoundation.org
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Thinh.Nguyen@...opsys.com, jackp@...eaurora.org
Subject: Re: [PATCH] usb: dwc3: gadget: Return success always for kick
 transfer in ep queue



On 5/7/2021 5:34 AM, Felipe Balbi wrote:
> Wesley Cheng <wcheng@...eaurora.org> writes:
> 
>> If an error is received when issuing a start or update transfer
>> command, the error handler will stop all active requests (including
>> the current USB request), and call dwc3_gadget_giveback() to notify
>> function drivers of the requests which have been stopped.  Avoid
>> returning an error for kick transfer during EP queue, to remove
>> duplicate cleanup operations on the request being queued.
>>
>> Signed-off-by: Wesley Cheng <wcheng@...eaurora.org>

Hi Felipe,
> 
> do you want to add a Fixes here? :-)
> 
Sure, will do!

> We should probably Cc stable too.
> 
Got it.

Thanks
Wesley Cheng

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project