linux-kernel - Re: [PATCH] bluetooth: fix potential gfp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <C8DBF891-99FF-4B21-A7EA-57C07DCF1DFF@holtmann.org>
Date:   Fri, 7 May 2021 21:22:09 +0200
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Johan Hovold <johan@...nel.org>
Cc:     Pavel Skripkin <paskripkin@...il.com>,
        Johan Hedberg <johan.hedberg@...il.com>,
        Luiz Augusto von Dentz <luiz.dentz@...il.com>,
        Bluetooth Kernel Mailing List 
        <linux-bluetooth@...r.kernel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bluetooth: fix potential gfp

Hi Johan,

>>>>>>> In qca_power_shutdown() qcadev local variable is
>>>>>>> initialized by hu->serdev.dev private data, but
>>>>>>> hu->serdev can be NULL and there is a check for it.
>>>>>>> 
>>>>>>> Since, qcadev is not used before
>>>>>>> 
>>>>>>> 	if (!hu->serdev)
>>>>>>> 		return;
>>>>>>> 
>>>>>>> we can move its initialization after this "if" to
>>>>>>> prevent gfp.
>>>>>>> 
>>>>>>> Signed-off-by: Pavel Skripkin <paskripkin@...il.com>
>>>>>>> ---
>>>>>>> drivers/bluetooth/hci_qca.c | 4 ++--
>>>>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>>>> 
>>>>>> patch has been applied to bluetooth-next tree.
>>>>> 
>>>>> Why did you pick the v1 when it is clear from thread that a v2 has been
>>>>> posted?
>>>> 
>>>> because I only saw that email after I applied the patch and the v2 is
>>>> nowhere in sight as it seems. If it shows up, I replace this one then.
>>> 
>>> Here it is
>>> 
>>> 	https://lore.kernel.org/lkml/20210503100605.5223-1-paskripkin@gmail.com/
>> 
>> seems to have missed my inbox. Fixed now.
> 
> Would you mind adding my Reviewed-by tag from the reply to that patch as
> well?

sure thing.

Regards

Marcel