linux-kernel - Re: [PATCH 1/2] dt-bindings: pwm: renesas,tpu-pwm: Improve json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210507222157.GA3000824@robh.at.kernel.org>
Date:   Fri, 7 May 2021 17:21:57 -0500
From:   Rob Herring <robh@...nel.org>
To:     Geert Uytterhoeven <geert+renesas@...der.be>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, Lee Jones <lee.jones@...aro.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
        Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        devicetree@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        uclinux-h8-devel@...ts.sourceforge.jp, linux-pwm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: pwm: renesas,tpu-pwm: Improve
 json-schema

On Fri, May 07, 2021 at 10:25:12AM +0200, Geert Uytterhoeven wrote:
>   - Include the general PWM controller schema,
>   - Make clocks, power-domains, and resets properties required.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
>  .../bindings/pwm/renesas,tpu-pwm.yaml         | 19 ++++++++++++++++++-
>  1 file changed, 18 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.yaml b/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.yaml
> index aa9a4570c9068226..3a072ee29815c695 100644
> --- a/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.yaml
> +++ b/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.yaml
> @@ -58,8 +58,25 @@ required:
>    - compatible
>    - reg
>    - '#pwm-cells'
> +  - clocks
> +  - power-domains
>  
> -additionalProperties: false
> +allOf:
> +  - $ref: pwm.yaml#

This doesn't add any other properties, so you can keep 
'additionalProperties: false'. 

> +
> +  - if:
> +      not:
> +        properties:
> +          compatible:
> +            contains:
> +              enum:
> +                - renesas,tpu-r8a73a4
> +                - renesas,tpu-r8a7740
> +    then:
> +      required:
> +        - resets
> +
> +unevaluatedProperties: false
>  
>  examples:
>    - |
> -- 
> 2.25.1
>