linux-kernel - Re: [PATCH 1/1] um: fix error return code in slip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <70835fd6-69ba-8bff-65a1-aad83e400a52@cambridgegreys.com>
Date:   Sat, 8 May 2021 10:13:02 +0100
From:   Anton Ivanov <anton.ivanov@...bridgegreys.com>
To:     Zhen Lei <thunder.leizhen@...wei.com>,
        Jeff Dike <jdike@...toit.com>,
        Richard Weinberger <richard@....at>,
        Andrew Morton <akpm@...l.org>,
        linux-um <linux-um@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] um: fix error return code in slip_open()

On 08/05/2021 04:13, Zhen Lei wrote:
> Fix to return a negative error code from the error handling case instead
> of 0, as done elsewhere in this function.
> 
> Fixes: a3c77c67a443 ("[PATCH] uml: slirp and slip driver cleanups and fixes")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zhen Lei <thunder.leizhen@...wei.com>
> ---
>   arch/um/drivers/slip_user.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/um/drivers/slip_user.c b/arch/um/drivers/slip_user.c
> index 482a19c5105c..7334019c9e60 100644
> --- a/arch/um/drivers/slip_user.c
> +++ b/arch/um/drivers/slip_user.c
> @@ -145,7 +145,8 @@ static int slip_open(void *data)
>   	}
>   	sfd = err;
>   
> -	if (set_up_tty(sfd))
> +	err = set_up_tty(sfd);
> +	if (err)
>   		goto out_close2;
>   
>   	pri->slave = sfd;
> 
Acked-By: anton.ivanov@...bridgegreys.com

-- 
Anton R. Ivanov
Cambridgegreys Limited. Registered in England. Company Number 10273661
https://www.cambridgegreys.com/