linux-kernel - Re: [PATCH v2 09/49] staging: sm750fb: Rename sm750_set_power

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210508095106.GL1955@kadam>
Date:   Sat, 8 May 2021 12:51:06 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Pavle Rohalj <pavle.rohalj@...il.com>
Cc:     sudipm.mukherjee@...il.com, teddy.wang@...iconmotion.com,
        gregkh@...uxfoundation.org, linux-fbdev@...r.kernel.org,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 09/49] staging: sm750fb: Rename sm750_set_power_mode
 function parameter

On Tue, Apr 06, 2021 at 11:36:21PM -0700, Pavle Rohalj wrote:
> Fix "Avoid CamelCase" checkpatch.pl check for the function parameter
> powerMode of function sm750_set_power_mode.
> 
> Signed-off-by: Pavle Rohalj <pavle.rohalj@...il.com>
> ---
>  drivers/staging/sm750fb/ddk750_power.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/sm750fb/ddk750_power.h b/drivers/staging/sm750fb/ddk750_power.h
> index 4756db1ccb9c..d43942d6a5aa 100644
> --- a/drivers/staging/sm750fb/ddk750_power.h
> +++ b/drivers/staging/sm750fb/ddk750_power.h
> @@ -15,7 +15,7 @@ enum dpms {
>  }
>  
>  void ddk750_set_dpms(enum dpms state);
> -void sm750_set_power_mode(unsigned int powerMode);
> +void sm750_set_power_mode(unsigned int power_mode);

This should just be "mode" to match the function.

Anyway, I just realized now that I'm somehow reviewing ancient patches
so I'm going to stop.

regards,
dan carpenter