linux-kernel - Re: [PATCH V2] media: i2c: ov2659: Fix an error message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+V-a8sd7GYGWqvDQX4Zc1Z-t+L1oSSmYUpHrVkB0-6mqVhnBA@mail.gmail.com>
Date:   Sat, 8 May 2021 13:53:41 +0100
From:   "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To:     christophe.jaillet@...adoo.fr
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Benoit Parrot <bparrot@...com>,
        Hans Verkuil <hans.verkuil@...co.com>,
        linux-media <linux-media@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH V2] media: i2c: ov2659: Fix an error message

Hi Christophe,

Thank you for the patch.

On Wed, May 5, 2021 at 9:17 PM Christophe JAILLET
<christophe.jaillet@...adoo.fr> wrote:
>
> 'ret' is known to be 0 here and printing -ENODEV wouldn't be really
> helpful. So remove it from the error message.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
> V2: Remove the Fixes tag. It doesn't really fix something, it just removes
>     a useless information.
>     Just remove ret. No need to add something else.
> ---
>  drivers/media/i2c/ov2659.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
Acked-by: Lad Prabhakar <prabhakar.csengg@...il.com>

Cheers,
Prabhakar

> diff --git a/drivers/media/i2c/ov2659.c b/drivers/media/i2c/ov2659.c
> index 42f64175a6df..6bbbb94fdda4 100644
> --- a/drivers/media/i2c/ov2659.c
> +++ b/drivers/media/i2c/ov2659.c
> @@ -1368,8 +1368,7 @@ static int ov2659_detect(struct v4l2_subdev *sd)
>                 id = OV265X_ID(pid, ver);
>                 if (id != OV2659_ID) {
>                         dev_err(&client->dev,
> -                               "Sensor detection failed (%04X, %d)\n",
> -                               id, ret);
> +                               "Sensor detection failed (%04X)\n", id);
>                         ret = -ENODEV;
>                 } else {
>                         dev_info(&client->dev, "Found OV%04X sensor\n", id);
> --
> 2.30.2
>