linux-kernel - RE: [PATCH V2 08/13] dt-bindings: imx: gpcv2: add support for optional resets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB6PR0402MB2760B7FDE5AEC56C782CC59A88569@DB6PR0402MB2760.eurprd04.prod.outlook.com>
Date:   Sat, 8 May 2021 00:50:01 +0000
From:   Peng Fan <peng.fan@....com>
To:     Rob Herring <robh@...nel.org>,
        Frieder Schrempf <frieder.schrempf@...tron.de>
CC:     "Peng Fan (OSS)" <peng.fan@....nxp.com>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        dl-linux-imx <linux-imx@....com>,
        "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
        "l.stach@...gutronix.de" <l.stach@...gutronix.de>,
        "krzk@...nel.org" <krzk@...nel.org>,
        "agx@...xcpu.org" <agx@...xcpu.org>,
        "marex@...x.de" <marex@...x.de>,
        "andrew.smirnov@...il.com" <andrew.smirnov@...il.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Jacky Bai <ping.bai@....com>,
        "aford173@...il.com" <aford173@...il.com>,
        Abel Vesa <abel.vesa@....com>
Subject: RE: [PATCH V2 08/13] dt-bindings: imx: gpcv2: add support for
 optional resets

> Subject: Re: [PATCH V2 08/13] dt-bindings: imx: gpcv2: add support for
> optional resets
> 
> On Thu, May 06, 2021 at 08:43:17AM +0200, Frieder Schrempf wrote:
> > On 06.05.21 03:04, Peng Fan (OSS) wrote:
> > > From: Lucas Stach <l.stach@...gutronix.de>
> > >
> > > For some domains the resets of the devices in the domain are not
> > > automatically triggered. Add an optional resets property to allow
> > > the GPC driver to trigger those resets explicitly.
> > >
> > > The resets belong to devices located inside the power domain, which
> > > need to be held in reset across the power-up sequence. So we have no
> > > means to specify what each reset is in a generic power-domain
> > > binding. Same situation as with the clocks in this binding actually.
> >
> > My understanding was that Rob wanted this explanation to be contained in
> the binding docs itself and not only in the commit message, but I might be
> wrong.
> 
> Yes, that would be better.

Sure, I will include that in V3.

Thanks,
Peng.

> 
> >
> > >
> > > Signed-off-by: Lucas Stach <l.stach@...gutronix.de>
> > > Signed-off-by: Peng Fan <peng.fan@....com>
> > > ---
> > >  Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml | 7
> > > +++++++
> > >  1 file changed, 7 insertions(+)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml
> > > b/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml
> > > index a96e6dbf1858..4330c73a2c30 100644
> > > --- a/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml
> > > +++ b/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml
> > > @@ -66,6 +66,13 @@ properties:
> > >
> > >            power-supply: true
> > >
> > > +          resets:
> > > +            description: |
> > > +              A number of phandles to resets that need to be
> asserted during
> > > +              power-up sequencing of the domain.
> > > +            minItems: 1
> > > +            maxItems: 4
> > > +
> > >          required:
> > >            - '#power-domain-cells'
> > >            - reg
> > >