linux-kernel - Re: [PATCH] spi: spi-fsl-dspi: Fix a resource leak in an error handling path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210509192632.2nzgwckpai34hgnr@skbuf>
Date:   Sun, 9 May 2021 22:26:32 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     broonie@...nel.org, maitysanchayan@...il.com,
        linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] spi: spi-fsl-dspi: Fix a resource leak in an error
 handling path

On Sun, May 09, 2021 at 09:12:27PM +0200, Christophe JAILLET wrote:
> 'dspi_request_dma()' should be undone by a 'dspi_release_dma()' call in the
> error handling path of the probe function, as already done in the remove
> function
> 
> Fixes: 90ba37033cb9 ("spi: spi-fsl-dspi: Add DMA support for Vybrid")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---

Reviewed-by: Vladimir Oltean <olteanv@...il.com>

Thanks!