linux-kernel - [PATCH] tools/power/turbostat: fix dump for AMD cpus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <c60a2dcd-acc4-a9da-6518-fc05165ae4ef@eginity.com>
Date:   Sun, 9 May 2021 05:08:55 -0400
From:   Dan Merillat <git@....eginity.com>
To:     Len Brown <lenb@...nel.org>, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH] tools/power/turbostat: fix dump for AMD cpus

turbostat --Dump exits early with status 243 (-13)

get_counters() calls get_msr_sum() on zen CPUS
for MSR_PKG_ENERGY_STAT, but per_cpu_msr_sum
has not been initialized.

Signed-off-by: Dan Merillat <git@....eginity.com>
---
 tools/power/x86/turbostat/turbostat.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/power/x86/turbostat/turbostat.c
b/tools/power/x86/turbostat/turbostat.c
index 47d3ba895d6d..c133fef270f6 100644
--- a/tools/power/x86/turbostat/turbostat.c
+++ b/tools/power/x86/turbostat/turbostat.c
@@ -6432,6 +6432,8 @@ int main(int argc, char **argv)

 	turbostat_init();

+	msr_sum_record();
+
 	/* dump counters and exit */
 	if (dump_only)
 		return get_and_dump_counters();
@@ -6443,7 +6445,6 @@ int main(int argc, char **argv)
 		return 0;
 	}

-	msr_sum_record();
 	/*
 	 * if any params left, it must be a command to fork
 	 */
-- 
2.31.1