linux-kernel - Re: [PATCH v2 1/2] printk: introduce dump_stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20210508175250.d28548e312bfae4c8d779e2d@linux-foundation.org>
Date:   Sat, 8 May 2021 17:52:50 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Alexander Potapenko <glider@...gle.com>
Cc:     pmladek@...e.com, mingo@...nel.org, bo.he@...el.com,
        yanmin_zhang@...ux.intel.com, psodagud@...cinc.com,
        dvyukov@...gle.com, elver@...gle.com, linux-kernel@...r.kernel.org,
        ryabinin.a.a@...il.com, he@...gle.com
Subject: Re: [PATCH v2 1/2] printk: introduce dump_stack_lvl()

On Thu,  6 May 2021 12:54:04 +0200 Alexander Potapenko <glider@...gle.com> wrote:

> dump_stack() is used for many different cases, which may require a log
> level consistent with other kernel messages surrounding the dump_stack()
> call.
> Without that, certain systems that are configured to ignore the default
> level messages will miss stack traces in critical error reports.
> 
> This patch introduces dump_stack_lvl() that behaves similarly to
> dump_stack(), but accepts a custom log level.
> The old dump_stack() becomes equal to dump_stack_lvl(KERN_DEFAULT).
> 
> A somewhat similar patch has been proposed in 2012:
> https://lore.kernel.org/lkml/1332493269.2359.9.camel@hebo/
> , but wasn't merged.

Um yeah, I dropped the ball on that one, didn't I?  I suspect pretty
much all dump_stack() callsites should be using this.