linux-kernel - Re: 'make O=' indigestion with module signing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210509151112.GA839293@gmail.com>
Date:   Sun, 9 May 2021 17:11:12 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     David Howells <dhowells@...hat.com>
Cc:     Valdis Klētnieks <valdis.kletnieks@...edu>,
        David Woodhouse <dwmw2@...radead.org>,
        keyrings@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: 'make O=' indigestion with module signing


* David Howells <dhowells@...hat.com> wrote:

> Valdis Klētnieks <valdis.kletnieks@...edu> wrote:
> 
> > So the root cause was: 'make mrproper doesn't clean certs/' out enough,
> > and this chunk of certs/Makefile
> > ...
> > I admit not being sure how (or if) this should be fixed
> 
> It's tricky because CONFIG_MODULE_SIG_KEY may not point to a file, let alone a
> file that was autogenerated - it can be given a PKCS#11 URI, for instance.  I
> had to put in the autogeneration based on a magic config string value to stop
> randconfig blowing up - but it only does the autogeneration if you don't put
> in your own file there before building.
> 
> Possibly I can add something like:
> 
> 	clean-files := signing_key.pem x509.genkey
> 
> inside the
> 
> 	ifeq ($(CONFIG_MODULE_SIG_KEY),"certs/signing_key.pem")
> 	...
> 	endif
> 
> section.

Note that this bug is now upstream in Linus's tree and has broken
the deb-pkg distro kernel build method.

Would be nice to make 'make mrproper' work again.

Thanks,

	Ingo