linux-kernel - Re: [PATCH] vdpa_sim_blk: remove duplicate include of linux/blkdev.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210510070101.iimcdu7zkmx5on6a@steredhat>
Date:   Mon, 10 May 2021 09:01:01 +0200
From:   Stefano Garzarella <sgarzare@...hat.com>
To:     Wan Jiabing <wanjiabing@...o.com>
Cc:     "Michael S. Tsirkin" <mst@...hat.com>,
        Jason Wang <jasowang@...hat.com>,
        Stefan Hajnoczi <stefanha@...hat.com>,
        Max Gurtovoy <mgurtovoy@...dia.com>,
        virtualization@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org, kael_w@...h.net
Subject: Re: [PATCH] vdpa_sim_blk: remove duplicate include of linux/blkdev.h

On Mon, May 10, 2021 at 10:43:03AM +0800, Wan Jiabing wrote:
>In commit 7d189f617f83f ("vdpa_sim_blk: implement ramdisk behaviour")
>linux/blkdev.h was included here causing the duplicate include.
>Remove the later duplicate include.
>
>Signed-off-by: Wan Jiabing <wanjiabing@...o.com>
>---
> drivers/vdpa/vdpa_sim/vdpa_sim_blk.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c b/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
>index 5bfe1c281645..a790903f243e 100644
>--- a/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
>+++ b/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
>@@ -15,7 +15,6 @@
> #include <linux/blkdev.h>
> #include <linux/vringh.h>
> #include <linux/vdpa.h>
>-#include <linux/blkdev.h>
> #include <uapi/linux/virtio_blk.h>
>
> #include "vdpa_sim.h"
>-- 
>2.20.1
>

Ooops...

Thanks for fixing this!

Reviewed-by: Stefano Garzarella <sgarzare@...hat.com>