linux-kernel - Re: broonie-sound/for-next bisection: baseline.bootrr.asoc-simple-card-probed on kontron-sl28-var3-ads2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <99b3cd8db134d9682c16784f75f40bae@walle.cc>
Date:   Mon, 10 May 2021 13:52:22 +0200
From:   Michael Walle <michael@...le.cc>
To:     Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
Cc:     Mark Brown <broonie@...nel.org>,
        Guillaume Tucker <guillaume.tucker@...labora.com>,
        kernelci-results@...ups.io, Heiko Thiery <heiko.thiery@...il.com>,
        alsa-devel@...a-project.org, Jaroslav Kysela <perex@...ex.cz>,
        Liam Girdwood <lgirdwood@...il.com>,
        Takashi Iwai <tiwai@...e.com>,
        Stephan Gerhold <stephan@...hold.net>,
        Thierry Reding <treding@...dia.com>,
        Jon Hunter <jonathanh@...dia.com>, linux-kernel@...r.kernel.org
Subject: Re: broonie-sound/for-next bisection:
 baseline.bootrr.asoc-simple-card-probed on kontron-sl28-var3-ads2

Hi,

Am 2021-05-10 01:16, schrieb Kuninori Morimoto:
> I'm sorry for my late response. Japan was holiday
> 
>>  _But_ later
>> asoc_simple_canonicalize_cpu() will reset the dai_name pointer to
>> NULL in simple_parse_node() if "single" is 1 and then we end up
>> having two links with the same name.
> 
> Ahh, OK thanks.
> I think understand that why my posted patch
> (= 59c35c44a9cf89a83a9 "ASoC: simple-card: add simple_parse_node()")
> breaks your board.
> 
> I will try to fixup the issue.
> 
> Thank you for your help !!

I've just tested your new patches. Unfortunately, it was very
successful. I've also traced the is_single_links and it is still
1 for this board. Is this correct?

Still these two questions are open:
>> Which begs the two questions:
>> (1) What is "single" actually and when should it be 1?
>> (2) If single is 1, then the sysfs file will be named 
>> "(null)-codec-name".
>>     Do we want that?

-michael