linux-kernel - Re: [PATCH 5.10 104/299] crypto: stm32/hash - Fix PM reference leak on stm32-hash.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210510120554.GB3547@duo.ucw.cz>
Date:   Mon, 10 May 2021 14:05:54 +0200
From:   Pavel Machek <pavel@...x.de>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Shixin Liu <liushixin2@...wei.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH 5.10 104/299] crypto: stm32/hash - Fix PM reference leak
 on stm32-hash.c

Hi!

> pm_runtime_get_sync will increment pm usage counter even it failed.
> Forgetting to putting operation will result in reference leak here.
> Fix it by replacing it with pm_runtime_resume_and_get to keep usage
> counter balanced.

I believe we need to enforce "patches need to be tested" rule at least
against robots.

Code was correct in 3/4 instances, this introduces bugs. Yes, last one
needs fixing.

Best regards,
								Pavel

> +++ b/drivers/crypto/stm32/stm32-hash.c
> @@ -812,7 +812,7 @@ static void stm32_hash_finish_req(struct ahash_request *req, int err)
>  static int stm32_hash_hw_init(struct stm32_hash_dev *hdev,
>  			      struct stm32_hash_request_ctx *rctx)
>  {
> -	pm_runtime_get_sync(hdev->dev);
> +	pm_runtime_resume_and_get(hdev->dev);
>  
>  	if (!(HASH_FLAGS_INIT & hdev->flags)) {
>  		stm32_hash_write(hdev, HASH_CR, HASH_CR_INIT);
> @@ -961,7 +961,7 @@ static int stm32_hash_export(struct ahash_request *req, void *out)
>  	u32 *preg;
>  	unsigned int i;
>  
> -	pm_runtime_get_sync(hdev->dev);
> +	pm_runtime_resume_and_get(hdev->dev);
>  
>  	while ((stm32_hash_read(hdev, HASH_SR) & HASH_SR_BUSY))
>  		cpu_relax();
> @@ -999,7 +999,7 @@ static int stm32_hash_import(struct ahash_request *req, const void *in)
>  
>  	preg = rctx->hw_context;
>  
> -	pm_runtime_get_sync(hdev->dev);
> +	pm_runtime_resume_and_get(hdev->dev);
>  
>  	stm32_hash_write(hdev, HASH_IMR, *preg++);
>  	stm32_hash_write(hdev, HASH_STR, *preg++);

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)