linux-kernel - Re: [PATCH] nvmem: sprd: Fix an error message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAfSe-srh_3S-AStLe7f+KuKQ2MY07OyhZ22nnEumE+uE8gUyA@mail.gmail.com>
Date:   Mon, 10 May 2021 15:18:07 +0800
From:   Chunyan Zhang <zhang.lyra@...il.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Orson Zhai <orsonzhai@...il.com>,
        Baolin Wang <baolin.wang7@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Freeman Liu <freeman.liu@...soc.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] nvmem: sprd: Fix an error message

On Sat, 8 May 2021 at 01:02, Christophe JAILLET
<christophe.jaillet@...adoo.fr> wrote:
>
> 'ret' is known to be 0 here.
> The expected error status is stored in 'status', so use it instead.
>
> Also change %d in %u, because status is an u32, not a int.
>
> Fixes: 096030e7f449 ("nvmem: sprd: Add Spreadtrum SoCs eFuse support")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Thanks.
Acked-by: Chunyan Zhang <zhang.lyra@...il.com>


> ---
>  drivers/nvmem/sprd-efuse.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvmem/sprd-efuse.c b/drivers/nvmem/sprd-efuse.c
> index 5d394559edf2..e3e721d4c205 100644
> --- a/drivers/nvmem/sprd-efuse.c
> +++ b/drivers/nvmem/sprd-efuse.c
> @@ -234,7 +234,7 @@ static int sprd_efuse_raw_prog(struct sprd_efuse *efuse, u32 blk, bool doub,
>         status = readl(efuse->base + SPRD_EFUSE_ERR_FLAG);
>         if (status) {
>                 dev_err(efuse->dev,
> -                       "write error status %d of block %d\n", ret, blk);
> +                       "write error status %u of block %d\n", status, blk);
>
>                 writel(SPRD_EFUSE_ERR_CLR_MASK,
>                        efuse->base + SPRD_EFUSE_ERR_CLR);
> --
> 2.30.2
>