linux-kernel - Re: [PATCH v2] i2c: I2C_HISI should depend on ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <308d0e42-33ff-4eed-3933-dededb92b723@hisilicon.com>
Date:   Mon, 10 May 2021 21:00:31 +0800
From:   Yicong Yang <yangyicong@...ilicon.com>
To:     Geert Uytterhoeven <geert+renesas@...der.be>,
        Wei Xu <xuwei5@...ilicon.com>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>
CC:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Dmitry Osipenko <digetx@...il.com>,
        <linux-i2c@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] i2c: I2C_HISI should depend on ACPI

On 2021/5/4 17:06, Geert Uytterhoeven wrote:
> The HiSilicon Kunpeng I2C controller driver relies on ACPI to probe for
> its presence.  Hence add a dependency on ACPI, to prevent asking the
> user about this driver when configuring a kernel without ACPI firmware
> support.
> 
> Fixes: d62fbdb99a85730a ("i2c: add support for HiSilicon I2C controller")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>

Acked-by: Yicong Yang <yangyicong@...ilicon.com>

> ---
> v2:
>   - Drop dependency on ARCH_HISI, as this is a public IP which doesn't
>     specifically depend on ARCH_HISI.
> ---
>  drivers/i2c/busses/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index b5b4e0d0ff4dd0bc..226c0b79eac030fa 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -647,7 +647,7 @@ config I2C_HIGHLANDER
>  
>  config I2C_HISI
>  	tristate "HiSilicon I2C controller"
> -	depends on ARM64 || COMPILE_TEST
> +	depends on (ARM64 && ACPI) || COMPILE_TEST
>  	help
>  	  Say Y here if you want to have Hisilicon I2C controller support
>  	  available on the Kunpeng Server.
>