linux-kernel - Re: [PULL] topic/iomem-mmap-vs-gup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YJjg3DRnG1RG6VDK@infradead.org>
Date:   Mon, 10 May 2021 08:29:32 +0100
From:   Christoph Hellwig <hch@...radead.org>
To:     Daniel Vetter <daniel.vetter@...ll.ch>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Tomasz Figa <tfiga@...omium.org>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        DRI Development <dri-devel@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Linux-MM <linux-mm@...ck.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Media Mailing List <linux-media@...r.kernel.org>,
        linux-samsung-soc <linux-samsung-soc@...r.kernel.org>
Subject: Re: [PULL] topic/iomem-mmap-vs-gup

On Mon, May 10, 2021 at 09:16:58AM +0200, Daniel Vetter wrote:
> > End result: not pulling it, unless somebody can explain to me in small
> > words why I'm wrong and have the mental capacity of a damaged rodent.
> 
> No rodents I think, just more backstory of how this all fits. tldr;
> pin_user_pages is the only safe use of this vb2 userptr thing.

Yes, which is why I advocate for just ripping the follow_pfn path
out entirely.  It could have been used for crazy ad dangerous peer to
peer transfers outside of any infrastructure making it safe, or for
pre-CMA kernel memory carveouts for lage contiguous memory allocations
(which are pretty broken by design as well).  So IMHO the only sensible
thing is to remove this cruft entirely, and if it breaks a currently
working setup (which I think is unlikely) we'll have to make sure it
can work the proper way.