linux-kernel - Re: [PATCH v5 3/3] asm-generic/io.h: warn in inb() and friends with undefined PCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 10 May 2021 16:06:07 +0200
From:   Niklas Schnelle <schnelle@...ux.ibm.com>
To:     Arnd Bergmann <arnd@...db.de>, kernel test robot <lkp@...el.com>
Cc:     Vineet Gupta <vgupta@...opsys.com>,
        "David S. Miller" <davem@...emloft.net>, kbuild-all@...ts.01.org,
        Networking <netdev@...r.kernel.org>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        clang-built-linux <clang-built-linux@...glegroups.com>,
        linux-arch <linux-arch@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-s390 <linux-s390@...r.kernel.org>
Subject: Re: [PATCH v5 3/3] asm-generic/io.h: warn in inb() and friends with
 undefined PCI_IOBASE

On Mon, 2021-05-10 at 15:43 +0200, Arnd Bergmann wrote:
> On Mon, May 10, 2021 at 3:30 PM kernel test robot <lkp@...el.com> wrote:
> > All warnings (new ones prefixed by >>):
> > 
> >    In file included from include/linux/kernel.h:10,
> >                     from include/linux/list.h:9,
> >                     from include/linux/module.h:12,
> >                     from drivers/net/arcnet/com20020.c:31:
> >    drivers/net/arcnet/com20020.c: In function 'com20020_reset':
> > > > include/linux/compiler.h:70:32: warning: 'inbyte' is used uninitialized in this function [-Wuninitialized]
> >       70 |   (__if_trace.miss_hit[1]++,1) :  \
> >          |                                ^
> >    drivers/net/arcnet/com20020.c:286:9: note: 'inbyte' was declared here
> >      286 |  u_char inbyte;
> >          |         ^~~~~~
> 
> This looks like a real problem with the patch: the insb()/insw()/insl() helpers
> should memset(buffer, 0xff, size) to avoid using random stack data.
> 
>         Arnd


Yes I agree, will send a v6 shortly. Thanks.