linux-kernel - Re: [PATCH v3] dmaengine: fsl-qdma: check dma_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YJlB7XutrKJ0vq6n@vkoul-mobl.Dlink>
Date:   Mon, 10 May 2021 19:53:41 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Robin Gong <yibin.gong@....com>
Cc:     dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] dmaengine: fsl-qdma: check dma_set_mask return value

On 26-04-21, 16:59, Robin Gong wrote:
> For fix below warning reported by static code analysis tool like Coverity
> from Synopsys:
> 
> 'CID 12285639 (#1 of 2): Unchecked return value (CHECKED_RETURN)'

This should be:
Addresses-Coverity-ID: 12285639 ("Unchecked return value")

I have fixed that up and applied
> 
> Signed-off-by: Robin Gong <yibin.gong@....com>
> ---
>  drivers/dma/fsl-qdma.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/fsl-qdma.c b/drivers/dma/fsl-qdma.c
> index ed2ab46..045ead4 100644
> --- a/drivers/dma/fsl-qdma.c
> +++ b/drivers/dma/fsl-qdma.c
> @@ -1235,7 +1235,11 @@ static int fsl_qdma_probe(struct platform_device *pdev)
>  	fsl_qdma->dma_dev.device_synchronize = fsl_qdma_synchronize;
>  	fsl_qdma->dma_dev.device_terminate_all = fsl_qdma_terminate_all;
>  
> -	dma_set_mask(&pdev->dev, DMA_BIT_MASK(40));
> +	ret = dma_set_mask(&pdev->dev, DMA_BIT_MASK(40));
> +	if (ret) {
> +		dev_err(&pdev->dev, "dma_set_mask failure.\n");
> +		return ret;
> +	}
>  
>  	platform_set_drvdata(pdev, fsl_qdma);
>  
> -- 
> 2.7.4

-- 
~Vinod