linux-kernel - Re: [PATCH] reset: a10sr: add missing of_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f42e5936139f75968520cf76c359e079b49b1dcb.camel@pengutronix.de>
Date:   Mon, 10 May 2021 09:50:34 +0200
From:   Philipp Zabel <p.zabel@...gutronix.de>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Thor Thayer <thor.thayer@...ux.intel.com>,
        linux-kernel@...r.kernel.org
Cc:     kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] reset: a10sr: add missing of_match_table reference

On Fri, 2021-05-07 at 07:28 -0400, Krzysztof Kozlowski wrote:
> The driver defined of_device_id table but did not use it with
> of_match_table.  This prevents usual matching via devicetree and causes
> a W=1 warning:
> 
>   drivers/reset/reset-a10sr.c:111:34: warning:
>     ‘a10sr_reset_of_match’ defined but not used [-Wunused-const-variable=]
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Fixes: 627006820268 ("reset: Add Altera Arria10 SR Reset Controller")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
> ---
>  drivers/reset/reset-a10sr.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/reset/reset-a10sr.c b/drivers/reset/reset-a10sr.c
> index 7eacc89382f8..99b3bc8382f3 100644
> --- a/drivers/reset/reset-a10sr.c
> +++ b/drivers/reset/reset-a10sr.c
> @@ -118,6 +118,7 @@ static struct platform_driver a10sr_reset_driver = {
>  	.probe	= a10sr_reset_probe,
>  	.driver = {
>  		.name		= "altr_a10sr_reset",
> +		.of_match_table	= a10sr_reset_of_match,
>  	},
>  };
>  module_platform_driver(a10sr_reset_driver);

Thank you, applied to reset/next.

regards
Philipp