linux-kernel - Re: Subject: [PATCH] staging: qlge: removed unnecessary debug message to fix coding style warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 10 May 2021 16:55:14 +0200
From:   Fabio Aiuto <fabioaiuto83@...il.com>
To:     Ashish Vara <ashishvara89@...oo.com>
Cc:     manishc@...vell.com, GR-Linux-NIC-Dev@...vell.com,
        coiby.xu@...il.com, gregkh@...uxfoundation.org,
        netdev@...r.kernel.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: Subject: [PATCH] staging: qlge: removed unnecessary debug
 message to fix coding style warning

Hi Ashish,

in your subject line there is one Subject: too many

On Mon, May 10, 2021 at 08:13:37PM +0530, Ashish Vara wrote:
> From: Ashish Vara <ashishvara89@...oo.com>
> 
> removed unnecessary out of memory message to fix coding style warning.
> 
> Signed-off-by: Ashish Vara <ashishvara89@...oo.com>
> ---
>  drivers/staging/qlge/qlge_main.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c
> index c9dc6a852af4..a9e0bccc52d0 100644
> --- a/drivers/staging/qlge/qlge_main.c
> +++ b/drivers/staging/qlge/qlge_main.c
> @@ -2796,12 +2796,8 @@ static int qlge_init_bq(struct qlge_bq *bq)
>  
>  	bq->base = dma_alloc_coherent(&qdev->pdev->dev, QLGE_BQ_SIZE,
>  				      &bq->base_dma, GFP_ATOMIC);
> -	if (!bq->base) {
> -		netif_err(qdev, ifup, qdev->ndev,
> -			  "ring %u %s allocation failed.\n", rx_ring->cq_id,
> -			  bq_type_name[bq->type]);
> +	if (!bq->base)
>  		return -ENOMEM;
> -	}
>  
>  	bq->queue = kmalloc_array(QLGE_BQ_LEN, sizeof(struct qlge_bq_desc),
>  				  GFP_KERNEL);
> -- 
> 2.30.2
> 

thank you,

fabio