linux-kernel - Re: [PATCH v1 1/1] hwmon: (ltc2992) Put fwnode in error case during ->probe()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210510150228.GA1997561@roeck-us.net>
Date:   Mon, 10 May 2021 08:02:28 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Alexandru Tachici <alexandru.tachici@...log.com>,
        linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jean Delvare <jdelvare@...e.com>
Subject: Re: [PATCH v1 1/1] hwmon: (ltc2992) Put fwnode in error case during
 ->probe()

On Mon, May 10, 2021 at 01:01:36PM +0300, Andy Shevchenko wrote:
> In each iteration fwnode_for_each_available_child_node() bumps a reference
> counting of a loop variable followed by dropping in on a next iteration,
> 
> Since in error case the loop is broken, we have to drop a reference count
> by ourselves. Do it for port_fwnode in error case during ->probe().
> 
> Fixes: b0bd407e94b0 ("hwmon: (ltc2992) Add support")
> Cc: Alexandru Tachici <alexandru.tachici@...log.com>
> Signed-off-by: Andy Shevchenko <andy.shevchenko@...il.com>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/ltc2992.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hwmon/ltc2992.c b/drivers/hwmon/ltc2992.c
> index 4382105bf142..2a4bed0ab226 100644
> --- a/drivers/hwmon/ltc2992.c
> +++ b/drivers/hwmon/ltc2992.c
> @@ -900,11 +900,15 @@ static int ltc2992_parse_dt(struct ltc2992_state *st)
>  
>  	fwnode_for_each_available_child_node(fwnode, child) {
>  		ret = fwnode_property_read_u32(child, "reg", &addr);
> -		if (ret < 0)
> +		if (ret < 0) {
> +			fwnode_handle_put(child);
>  			return ret;
> +		}
>  
> -		if (addr > 1)
> +		if (addr > 1) {
> +			fwnode_handle_put(child);
>  			return -EINVAL;
> +		}
>  
>  		ret = fwnode_property_read_u32(child, "shunt-resistor-micro-ohms", &val);
>  		if (!ret)